From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 277DEC3DA40 for ; Fri, 21 Jul 2023 04:30:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbjGUE1z (ORCPT ); Fri, 21 Jul 2023 00:27:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbjGUE1y (ORCPT ); Fri, 21 Jul 2023 00:27:54 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EC9F268E; Thu, 20 Jul 2023 21:27:52 -0700 (PDT) Received: from [192.168.10.12] (unknown [39.45.151.35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id D8E616607027; Fri, 21 Jul 2023 05:27:41 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689913670; bh=iKsddZcHQfqrHPuhFqHvQKPW73Sg5qlkV+VjcVMfyNQ=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=S+vXr5QcpujtN7Eomq6xVbBtFRYy/Qn36tOKBjeamqj8kw0oHDbD8Pi64s1HgYKIx 5Ql7AOb99tROiFpRW/3Z1wBjIS37oRBRL7/upNkeCkWPQ9SgV+yquhVp+SFZn00pTv Mp1rNsm9RGGWFfwdzpO6+K9uM7DdIJXMxLc0SmiPqBIHQj54g16rm+My/s9TtqAb/E 4s6W1dV+LtuOFtQcQvtyNqsVFbwZSufIpXpRU4+bJCRzijEawwNkykwxHRI5c+fsBn n80+maVPwJVkr9wnKWo3cJhKrtNMackCmcOtxfl4yX3+o+yFirqolzMY6XpnnFYlmD VCeoAc+i3vgCg== Message-ID: Date: Fri, 21 Jul 2023 09:27:34 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Cc: Muhammad Usama Anjum , Alex Sierra , Alexander Viro , Andrew Morton , Axel Rasmussen , Christian Brauner , Cyrill Gorcunov , Dan Williams , David Hildenbrand , Greg KH , "Gustavo A . R . Silva" , "Liam R . Howlett" , Matthew Wilcox , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mike Rapoport , Nadav Amit , Pasha Tatashin , Paul Gofman , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yun Zhou , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel@collabora.com Subject: Re: fs/proc/task_mmu: Implement IOCTL for efficient page table scanning To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk References: <20230713101415.108875-6-usama.anjum@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Thank you Michał. On 7/21/23 12:28 AM, Michał Mirosław wrote: > b. rename match "flags" to 'page categories' everywhere - this makes > it easier to differentiate the ioctl()s categorisation of pages > from struct page flags; > c. change {required + excluded} to {inverted + required}. This was > rejected before, but I'd like to illustrate the difference. > Old interface can be translated to the new by: > categories_inverted = excluded_mask > categories_mask = required_mask | excluded_mask > categories_anyof_mask = anyof_mask > The new way allows filtering by: A & (B | !C) > categories_inverted = C > categories_mask = A > categories_anyof_mask = B | C Andrei and Danylo, Are you okay with these masks? It were you two who had proposed these. -- BR, Muhammad Usama Anjum