From: Shuah Khan <skhan@linuxfoundation.org>
To: Yun Lu <luyun@kylinos.cn>,
jikos@kernel.org, bentiss@kernel.org, shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftest: hid: add the missing tests directory
Date: Tue, 8 Oct 2024 13:33:05 -0600 [thread overview]
Message-ID: <e54c70db-a14d-43e6-b221-0c0712893ee7@linuxfoundation.org> (raw)
In-Reply-To: <20241008093120.3081899-1-luyun@kylinos.cn>
On 10/8/24 03:31, Yun Lu wrote:
> Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh")
> has added the run-hid-tools-tests.sh script for it to be installed, but
> I forgot to add the tests directory together.
>
> In fact, the run-hid-tools-tests.sh script uses the scripts in the tests
> directory to run tests. The tests directory also needs to be added to be
> installed
Include the error you are seeing in here.
>
> Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yun Lu <luyun@kylinos.cn>
> ---
> tools/testing/selftests/hid/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 38ae31bb07b5..662209f5fabc 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -18,6 +18,7 @@ TEST_PROGS += hid-usb_crash.sh
> TEST_PROGS += hid-wacom.sh
>
> TEST_FILES := run-hid-tools-tests.sh
> +TEST_FILES += tests
What about the files if any under the tests directory?
The install rule would handle the case, however, did
you verify that those are copied as well?
>
> CXX ?= $(CROSS_COMPILE)g++
>
thanks,
-- Shuah
next prev parent reply other threads:[~2024-10-08 19:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:31 [PATCH] selftest: hid: add the missing tests directory Yun Lu
2024-10-08 19:33 ` Shuah Khan [this message]
2024-10-09 6:45 ` luyun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54c70db-a14d-43e6-b221-0c0712893ee7@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luyun@kylinos.cn \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox