linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Justin Iurman <justin.iurman@uliege.be>
To: Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, dsahern@kernel.org, edumazet@google.com,
	kuba@kernel.org, horms@kernel.org, Shuah Khan <shuah@kernel.org>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v2 3/3] selftests: net: test for lwtunnel dst ref loops
Date: Thu, 20 Mar 2025 16:38:35 +0100	[thread overview]
Message-ID: <e5d0e758-f68f-4bf7-9fdc-b8171210e3a1@uliege.be> (raw)
In-Reply-To: <ffc4c4ba-7159-4a89-be52-9802ef21153e@redhat.com>

On 3/20/25 11:25, Paolo Abeni wrote:
> On 3/14/25 1:00 PM, Justin Iurman wrote:
>> As recently specified by commit 0ea09cbf8350 ("docs: netdev: add a note
>> on selftest posting") in net-next, the selftest is therefore shipped in
>> this series. However, this selftest does not really test this series. It
>> needs this series to avoid crashing the kernel. What it really tests,
>> thanks to kmemleak,
> 
> As a net-next follow-up you could force a kmemleak scan and check the
> result after each test case to really output a pass/fail message.

Sure. Could you point me to an example doing that? Not sure how I'd 
force it within the selftest.

> Also, still for net-next, please investigate if dropping or reducing the
> many sleep below could be possible (it's not clear to me why they are
> needed).

Of course, will do.

> I'll take is as-is to avoid blocking the fixes for trivial matters.

Thanks,
Justin

> Thanks,
> 
> Paolo
> 

  reply	other threads:[~2025-03-20 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250314120048.12569-1-justin.iurman@uliege.be>
2025-03-14 12:00 ` [PATCH net v2 3/3] selftests: net: test for lwtunnel dst ref loops Justin Iurman
2025-03-20 10:25   ` Paolo Abeni
2025-03-20 15:38     ` Justin Iurman [this message]
2025-03-20 16:46   ` [PATCH net v2 3/3] selftests: net: test for lwtunnel dst ref loops: manual merge Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e5d0e758-f68f-4bf7-9fdc-b8171210e3a1@uliege.be \
    --to=justin.iurman@uliege.be \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).