From: Shuah Khan <skhan@linuxfoundation.org>
To: Dev Jain <dev.jain@arm.com>,
shuah@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, Catalin.Marinas@arm.com,
will@kernel.org
Cc: broonie@kernel.org, ryan.roberts@arm.com,
Anshuman.Khandual@arm.com, aneesh.kumar@kernel.org,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] kselftest/arm64: Fix build warnings for ptrace
Date: Fri, 30 Aug 2024 07:27:37 -0600 [thread overview]
Message-ID: <e6027cfe-1a5e-424d-8ba8-f153d75b774e@linuxfoundation.org> (raw)
In-Reply-To: <20240830052911.4040970-1-dev.jain@arm.com>
On 8/29/24 23:29, Dev Jain wrote:
> A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
> introduced ksft_exit_fail_perror().
>
> Signed-off-by: Dev Jain <dev.jain@arm.com>
> ---
> tools/testing/selftests/arm64/abi/ptrace.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index e4fa507cbdd0..b51d21f78cf9 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -163,10 +163,10 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> static int do_child(void)
> {
> if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
> - ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
> + ksft_exit_fail_perror("PTRACE_TRACEME");
>
> if (raise(SIGSTOP))
> - ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> + ksft_exit_fail_perror("raise(SIGSTOP)");
>
> return EXIT_SUCCESS;
> }
Thanks for doing this.
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2024-08-30 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 5:29 [PATCH] kselftest/arm64: Fix build warnings for ptrace Dev Jain
2024-08-30 11:29 ` Mark Brown
2024-08-30 13:27 ` Shuah Khan [this message]
2024-08-30 16:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6027cfe-1a5e-424d-8ba8-f153d75b774e@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Anshuman.Khandual@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=aneesh.kumar@kernel.org \
--cc=broonie@kernel.org \
--cc=dev.jain@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox