From: Hari Bathini <hbathini@linux.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
"Naveen N. Rao" <naveen@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-trace-kernel@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le
Date: Wed, 6 Nov 2024 11:24:34 +0530 [thread overview]
Message-ID: <e6ba6084-e224-44c8-86e6-f3ae408209c1@linux.ibm.com> (raw)
In-Reply-To: <20241105195208.GC29862@gate.crashing.org>
On 06/11/24 1:22 am, Segher Boessenkool wrote:
> Hi!
>
> On Tue, Nov 05, 2024 at 06:17:51PM +0900, Masami Hiramatsu wrote:
>> On Tue, 5 Nov 2024 02:20:18 -0600
>> Segher Boessenkool <segher@kernel.crashing.org> wrote:
>>> On Mon, Nov 04, 2024 at 11:06:23PM +0530, Hari Bathini wrote:
>>>> Seems like a bit of misunderstanding there. Function entry here intends
>>>> to mean the actual start of function code (function prologue) - after
>>>> GEP and function profiling sequence (mflr r0; bl mcount).
>>>
>>> What you call "function entry" here simply does not exist. The compiler
>>> can -- and ***WILL***, ***DOES*** -- mix up all of that.
>>
>> Here is the "function entry" means the function address.
>
> "Function entry point". "Function entry" can mean whatever nebulous
> thing done at the start of a function :-)
>
> You're free to use your own terminology of course, but it help to use
> standard names for standard things!
>
>> Not the prologue.
>
> But that is literally what Hari said, so it confused me.
Sorry about that. I should have said.. maybe prologue or whatever
nebulous thing at the start of a function :-)
Basically, the address provided to test case can be any insn in the
function code expect what the kernel considers function entry address..
Thanks
Hari
next prev parent reply other threads:[~2024-11-06 6:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 19:19 [PATCH] selftests/ftrace: update kprobe syntax error test for ppc64le Hari Bathini
2024-11-01 20:59 ` Segher Boessenkool
2024-11-04 9:21 ` Hari Bathini
2024-11-04 9:44 ` Segher Boessenkool
2024-11-04 10:10 ` Hari Bathini
2024-11-04 10:36 ` Segher Boessenkool
2024-11-04 15:27 ` Steven Rostedt
2024-11-04 17:36 ` Hari Bathini
2024-11-05 8:20 ` Segher Boessenkool
2024-11-05 9:17 ` Masami Hiramatsu
2024-11-05 19:52 ` Segher Boessenkool
2024-11-06 5:54 ` Hari Bathini [this message]
2024-11-03 4:57 ` Masami Hiramatsu
2024-11-04 9:32 ` Hari Bathini
2024-11-05 8:37 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ba6084-e224-44c8-86e6-f3ae408209c1@linux.ibm.com \
--to=hbathini@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=rostedt@goodmis.org \
--cc=segher@kernel.crashing.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox