From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDFFC433F5 for ; Thu, 10 Feb 2022 17:34:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242846AbiBJReV (ORCPT ); Thu, 10 Feb 2022 12:34:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237578AbiBJReU (ORCPT ); Thu, 10 Feb 2022 12:34:20 -0500 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3DC8E70 for ; Thu, 10 Feb 2022 09:34:21 -0800 (PST) Received: by mail-il1-x12d.google.com with SMTP id m8so4931260ilg.7 for ; Thu, 10 Feb 2022 09:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/tW1HGdJGuZOMZnaP+IuCrurMw3sZjUR555ryvHuly8=; b=cwG4FzstvfQXqw15EB/NDvc1w0xZNKAkaDZS4ZQMnQ2HL2JpBNj8Z5Y5wYiQ2ujVeO WLcCdBgmAdSZEm30ZxlPTXcOizaaAWmBJLxIQpnvX4M/KTtKJtAe7V8N9ViEeCzhAZDz oufKRZaOGyXRdJZvCDWh2OlLwSlyOJ8/drnRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/tW1HGdJGuZOMZnaP+IuCrurMw3sZjUR555ryvHuly8=; b=GMyxwpVktZydohtFAbqnpd6BAEqAx1eOlh5/tnN3czBm2AIAQMYxfjBwdk35vCQHXw IG6gtsJE15dRAtb0aKED2eeDTRJNqdnDM8WdwxKe5Cll7Pndesl7q485+Ot8vaRJSTcT tXjShViZ68DMRWKngnvyS750sB3029NDrPrm/Ab5s9HTXgx0wmN3BbXd0uZ6A5UKcB0e kJo1eMIBj7uYnOS9CbVZkWaAht9/Ua8MFM1/a04E4o35F3lTNr+LJdZELPZTgfwuwgaG qwbcS4uy/7qBna/h0/T2EECmal26hUI9rGAB5rBfMnusyHMDgZLCqHGCpWg7jYyu7wTA PpGQ== X-Gm-Message-State: AOAM533KdG8tpSRQqnmjjofKrFcuPbLl49X1yJGUdK/qNwxxKnqQnKcM DEA6FRuOGoQVGpjMFhNJ12cARdzW5RxY5g== X-Google-Smtp-Source: ABdhPJwEKbE1y3rDTWjXLP59cL/Fr4JzYYmPkaFynHTcU6lUNsbLWMniGmzTYo1ikTPYP11+UXInww== X-Received: by 2002:a05:6e02:18c9:: with SMTP id s9mr4053986ilu.94.1644514461028; Thu, 10 Feb 2022 09:34:21 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id s16sm380928iow.10.2022.02.10.09.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 09:34:20 -0800 (PST) Subject: Re: [PATCH] selftests/exec: Add non-regular to TEST_GEN_PROGS To: Muhammad Usama Anjum , Eric Biederman , Kees Cook , Shuah Khan , Andrew Morton Cc: kernel@collabora.com, kernelci@groups.io, "kernelci.org bot" , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220210171323.1304501-1-usama.anjum@collabora.com> From: Shuah Khan Message-ID: Date: Thu, 10 Feb 2022 10:34:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220210171323.1304501-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 2/10/22 10:13 AM, Muhammad Usama Anjum wrote: > non-regular file needs to be compiled and then copied to the output > directory. Remove it from TEST_PROGS and add it to TEST_GEN_PROGS. This > removes error thrown by rsync when non-regular object isn't found: > > rsync: [sender] link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2) > rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1333) [sender=3.2.3] > > Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests") > Reported-by: "kernelci.org bot" > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index 551affb437fe1..a89ba6de79870 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -3,8 +3,8 @@ CFLAGS = -Wall > CFLAGS += -Wno-nonnull > CFLAGS += -D_GNU_SOURCE > > -TEST_PROGS := binfmt_script non-regular > -TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 > +TEST_PROGS := binfmt_script > +TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular > TEST_GEN_FILES := execveat.symlink execveat.denatured script subdir > # Makefile is a run-time dependency, since it's accessed by the execveat test > TEST_FILES := Makefile > This change looks good to me. regular is a binary and TEST_GEN_PROGS is where it belongs. Reviewed-by: Shuah Khan Also binfmt_script could be renamed to clearly identify that it is python script. This can be done in a separate patch. thanks, -- Shuah