From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D146628B4EE for ; Thu, 8 May 2025 20:18:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746735495; cv=none; b=Vt2zq+/2ujHjpSg4SR1M+ntBrSzMJAybf9+dFTfbcpvOXGuyDH+7eBYXJIELfjYw5MST358dY6ZkQVwF6poKsjMvpAXvw7RkqJ/+mq9Kb5n1XnQG/CLgzNMIdiAxtsgWTGsekpCSA7yBguQW0urmPawPAPAeukFP8qqYxyr8nDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746735495; c=relaxed/simple; bh=UojBaLSnI5K18WhmwXexF1bLjMn9YNs1CQZUt/Yl9eY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jn/NkUV31/6ofmJ6BwiWsd+fvBDy8SKbx3ozKoCb/GFUm7thXIR18QYFheXtjIaVLN+jw90ea70DhcH6envTCmNNI2jB6Gi3YPkKMOwUK4VbGgAfsrHmL3ImZ5gqmQy9qWtDhAUWaFfLYOkt4BZxU5qOJur7U6KZ2ZQmOvs/nAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=xZWoJtMG; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xZWoJtMG" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746735490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qCMU+yBPYWIBqtx4wjHgX8QEBpwX3EBt77ds4u9eyfA=; b=xZWoJtMGJ++IS2qmyND2yhJRoBrczbjEo2hlwL/TGR0NLs3NA+1wjTsb6ZNV39r57Kep0f WK/pqk/zOpQNeIUS/pr0Q3jfn53kCi2Xq8zdnPb2Sf+yQK3L9/klTRciIsSpxH8Mb0yP6n 92cBRHwE1HIrrJTuMlEikZ6N96AmwwQ= Date: Thu, 8 May 2025 13:18:05 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v6 02/14] riscv: sbi: remove useless parenthesis To: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: Samuel Holland , Andrew Jones , Deepak Gupta References: <20250424173204.1948385-1-cleger@rivosinc.com> <20250424173204.1948385-3-cleger@rivosinc.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Atish Patra In-Reply-To: <20250424173204.1948385-3-cleger@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 4/24/25 10:31 AM, Clément Léger wrote: > A few parenthesis in check for SBI version/extension were useless, > remove them. > > Signed-off-by: Clément Léger > --- > arch/riscv/kernel/sbi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/kernel/sbi.c b/arch/riscv/kernel/sbi.c > index 1989b8cade1b..1d44c35305a9 100644 > --- a/arch/riscv/kernel/sbi.c > +++ b/arch/riscv/kernel/sbi.c > @@ -609,7 +609,7 @@ void __init sbi_init(void) > } else { > __sbi_rfence = __sbi_rfence_v01; > } > - if ((sbi_spec_version >= sbi_mk_version(0, 3)) && > + if (sbi_spec_version >= sbi_mk_version(0, 3) && > sbi_probe_extension(SBI_EXT_SRST)) { > pr_info("SBI SRST extension detected\n"); > pm_power_off = sbi_srst_power_off; > @@ -617,8 +617,8 @@ void __init sbi_init(void) > sbi_srst_reboot_nb.priority = 192; > register_restart_handler(&sbi_srst_reboot_nb); > } > - if ((sbi_spec_version >= sbi_mk_version(2, 0)) && > - (sbi_probe_extension(SBI_EXT_DBCN) > 0)) { > + if (sbi_spec_version >= sbi_mk_version(2, 0) && > + sbi_probe_extension(SBI_EXT_DBCN) > 0) { > pr_info("SBI DBCN extension detected\n"); > sbi_debug_console_available = true; > } Reviewed-by: Atish Patra