From: Tejun Heo <tj@kernel.org>
To: Tao Cui <cui.tao@linux.dev>
Cc: josef@toxicopanda.com, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, andrii@kernel.org, eddyz87@gmail.com,
ast@kernel.org, daniel@iogearbox.net,
linux-kselftest@vger.kernel.org, Tao Cui <cuitao@kylinos.cn>,
ameryhung@gmail.com, alexei.starovoitov@gmail.com
Subject: Re: [RFC PATCH v10 4/4] docs: cgroup-v2: document the iocost BPF cost model attachment
Date: Fri, 16 Oct 2026 07:49:58 -1000 [thread overview]
Message-ID: <eae39daec12cf6f121cc5010574a6c03@kernel.org> (raw)
In-Reply-To: <20261003124045.1289305-5-cui.tao@linux.dev>
Hello, Tao.
On Sat, 03 Oct 2026 20:40:45 +0800, Tao Cui wrote:
> model The cost model in use - "linear"
> + or "bpf" while the BPF model
> + is in use
"linear" or "bpf" is enough here.
> + When CONFIG_BLK_CGROUP_IOCOST_BPF is enabled, a BPF cost model
> + can be bound to a device by attaching an "iocost_model_ops"
> + struct_ops carrying the whole disk's major:minor in its "dev"
> + member (a partition's major:minor is rejected). Attaching
> + creates the controller if needed, like an io.cost.model write
> + does, and
> + switches the device's pricing to the model; enabling and
Attaching now also populates the device's line, so the existing sentence
saying the line is populated on the first write to "io.cost.qos" or
"io.cost.model" needs updating. The paragraph also runs 21 lines with a
leftover break after "does, and". Can it be split into three, attaching,
model= selection and detaching, and removal and ctrl?
Thanks.
--
tejun
next prev parent reply other threads:[~2026-10-16 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 12:40 [RFC PATCH v10 0/4] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-10-03 12:40 ` [RFC PATCH v10 1/4] " Tao Cui
2026-10-03 13:21 ` bot+bpf-ci
2026-10-03 20:45 ` Alexei Starovoitov
2026-10-16 17:49 ` Tejun Heo
2026-10-03 12:40 ` [RFC PATCH v10 2/4] selftests/bpf: add iocost cost model test Tao Cui
2026-10-16 17:49 ` Tejun Heo
2026-10-03 12:40 ` [RFC PATCH v10 3/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary Tao Cui
2026-10-16 17:49 ` Tejun Heo
2026-10-03 12:40 ` [RFC PATCH v10 4/4] docs: cgroup-v2: document the iocost BPF cost model attachment Tao Cui
2026-10-16 17:49 ` Tejun Heo [this message]
2026-10-15 12:00 ` [RFC PATCH v10 0/4] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-10-16 17:49 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eae39daec12cf6f121cc5010574a6c03@kernel.org \
--to=tj@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox