Re: [PATCH v6 4/6] iommufd/selftest: Add mock_domain_cache_invalidate_user support

Jason Gunthorpe
2023-12-06T18:16:40Z

On Fri, Nov 17, 2023 at 05:07:15AM -0800, Yi Liu wrote:
> +static int
> +mock_domain_cache_invalidate_user(struct iommu_domain *domain,
> + struct iommu_user_data_array *array,
> + u32 *error_code)
> +{
> + struct mock_iommu_domain_nested *mock_nested =
> + container_of(domain, struct mock_iommu_domain_nested, domain);
> + struct iommu_hwpt_invalidate_selftest inv;
> + int rc = 0;
> + int i, j;
> +
> + if (domain->type != IOMMU_DOMAIN_NESTED)
> + return -EINVAL;

The core code already checked this, and it is only present on
domain_nested_ops so it is checked twice already..

Jason