From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Wieczor-Retman Maciej <maciej.wieczor-retman@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Shuah Khan <shuah@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 8/8] selftests/resctrl: Fix wrong format specifier
Date: Mon, 4 Sep 2023 16:14:47 +0300 (EEST) [thread overview]
Message-ID: <eb997572-3e51-22dc-2c61-f89a363a798@linux.intel.com> (raw)
In-Reply-To: <a10dfa9cbfec05e8056744bc5e3ac0697a4fbd9b.1693829810.git.maciej.wieczor-retman@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Mon, 4 Sep 2023, Wieczor-Retman Maciej wrote:
> A long unsigned int variable is passed to the ksft_print_msg() and the
> format specifier used expects a variable of type int.
>
> Change the format specifier to match the passed variable.
>
> Signed-off-by: Wieczor-Retman Maciej <maciej.wieczor-retman@intel.com>
> ---
> Changelog v2:
> - Added this patch to the series.
>
> tools/testing/selftests/resctrl/cache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c
> index d3cbb829ff6a..a5d082cd2d53 100644
> --- a/tools/testing/selftests/resctrl/cache.c
> +++ b/tools/testing/selftests/resctrl/cache.c
> @@ -294,7 +294,7 @@ int show_cache_info(unsigned long sum_llc_val, int no_of_bits,
> ret = platform && abs((int)diff_percent) > max_diff_percent &&
> (cmt ? (abs(avg_diff) > max_diff) : true);
>
> - ksft_print_msg("%s Check cache miss rate within %d%%\n",
> + ksft_print_msg("%s Check cache miss rate within %lu%%\n",
> ret ? "Fail:" : "Pass:", max_diff_percent);
>
> ksft_print_msg("Percent diff=%d\n", abs((int)diff_percent));
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2023-09-04 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 12:43 [PATCH v2 0/8] Add printf attribute to kselftest functions Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 1/8] selftests: Add printf attribute to ksefltest prints Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 2/8] selftests/cachestat: Fix print_cachestat format Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 3/8] selftests/openat2: Fix wrong format specifier Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 4/8] selftests/pidfd: Fix ksft print formats Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 5/8] selftests/sigaltstack: Fix wrong format specifier Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 6/8] selftests/kvm: Replace attribute with macro Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 7/8] selftests/mm: Substitute attribute with a macro Wieczor-Retman Maciej
2023-09-04 12:44 ` [PATCH v2 8/8] selftests/resctrl: Fix wrong format specifier Wieczor-Retman Maciej
2023-09-04 13:14 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb997572-3e51-22dc-2c61-f89a363a798@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).