From: Reinette Chatre <reinette.chatre@intel.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
<shuah@kernel.org>, <fenghua.yu@intel.com>
Cc: <ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] selftests/resctrl: Bug fix and optimization
Date: Wed, 27 Sep 2023 15:16:18 -0700 [thread overview]
Message-ID: <ec0a63fc-081a-a4bf-8ebf-d501b1d44cc0@intel.com> (raw)
In-Reply-To: <cover.1695369120.git.maciej.wieczor-retman@intel.com>
Hi Maciej,
On 9/22/2023 1:09 AM, Maciej Wieczor-Retman wrote:
> The resctrlfs.c file defines functions that interact with the resctrl FS
> while resctrl_val.c file defines functions that perform measurements on
> the cache. Run_benchmark() fits logically into the second file before
> resctrl_val() function that uses it.
nitpick ... if there are comments in one patch of the series please consider
if it applies to other places in the series.
>
> Move run_benchmark() from resctrlfs.c to resctrl_val.c and remove
> redundant part of the kernel-doc comment. Make run_benchmark() static
> and remove it from the header file.
>
> Patch series is based on [1] which is based on [2] which are based on
> ksefltest next branch.
ksefltest -> kselftest
Reinette
next prev parent reply other threads:[~2023-09-27 22:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 8:09 [PATCH v4 0/2] selftests/resctrl: Bug fix and optimization Maciej Wieczor-Retman
2023-09-22 8:10 ` [PATCH v4 1/2] selftests/resctrl: Fix schemata write error check Maciej Wieczor-Retman
2023-09-22 10:30 ` Ilpo Järvinen
2023-09-27 22:15 ` Reinette Chatre
2023-09-28 6:46 ` Maciej Wieczór-Retman
2023-09-28 21:25 ` Reinette Chatre
2023-09-29 6:09 ` Maciej Wieczór-Retman
2023-09-22 8:10 ` [PATCH v4 2/2] selftests/resctrl: Move run_benchmark() to a more fitting file Maciej Wieczor-Retman
2023-09-27 22:16 ` Reinette Chatre [this message]
2023-09-28 6:06 ` [PATCH v4 0/2] selftests/resctrl: Bug fix and optimization Maciej Wieczór-Retman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec0a63fc-081a-a4bf-8ebf-d501b1d44cc0@intel.com \
--to=reinette.chatre@intel.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox