From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789236EB64 for ; Thu, 5 Sep 2024 15:31:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725550269; cv=none; b=XeTEAKfIVuWSp9YJQ48DsniYeg3Lph2knaVfreBouYvIewA4JDBtFlHOyOwrRcBK89cZLAF/WxT2qOPCCGD4LUQMIETtmUpgb3Ljos4DQbTrR5KOBIu+dWcLgkC9ee+Cu3RkcrBNeUPNzBfCr97aA1lER0+FpJDqzjuMeCjmCBQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725550269; c=relaxed/simple; bh=sFctCV7/ED3u2naD+T9lfUOkvUysEjdKMEcKnHtcucY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n2buhQS6yODaDPS7Z2v+jpnkExHI79pMO3m1kg0J2xBJqAZEALGl1/XYZUH85c4+3gywtiqj//tmSO31b874u23cYFxA08U73hU+XRenmV329E83DQFNrU3vjTdZhOhwiQgCG4DKgGI6UFKrS7j8QGAUHvnBDRiijzohGejNiZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RwcCILlh; arc=none smtp.client-ip=209.85.166.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RwcCILlh" Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-39f51371baeso3102315ab.3 for ; Thu, 05 Sep 2024 08:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1725550265; x=1726155065; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dGxruLxENrhmwNeln8hIN5sMLYl6yZ1nExke/ImPg4o=; b=RwcCILlhc1IRJ0fNw0kw75rplvSxePP5xgrn5aFNlZf+ElLsuYX0S9uQQUzw6P+Xi+ 9Ga198Dp+X4AinNHk1jZy4/WsPEqTG1TN+gEzkzrg09Rh55rat9mRtQygXvh/JYIBBbP LqdycbcvCxEbUpjL3weR9oyRG3Ki9IkUEkw8U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725550265; x=1726155065; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dGxruLxENrhmwNeln8hIN5sMLYl6yZ1nExke/ImPg4o=; b=pFTqfMWxWHDuKFNqx7LQOj/C2EhWvU30XRNZlO7RLTdY1fhyC7J5EwOYiOjqNCvnfI Ns0xZWQlI6qRb3CTMwp0fKp9bpuYmGCTSAiWrpJCScTlIexWvcIQcvV7AjphUM3A11JG M3Zs+9bHpU+4Y4fVipBNy3UY+VEW1wPCcXzl+lX3lf4X2/frfJhbava37a8GBurB6iyW QIg/olD28e9QamtKwLib/2MKaYDYQwDw/1idivXY9EAddQM6F0WNqYvNYOd2RZGtgUGy SU7GiSRPWGD2wxAYr79oqXgIFyxgWdiCTeRUFTfI0zx7JUUW9DKHllhZvAsp3OI4TaL6 r+/A== X-Gm-Message-State: AOJu0YwZEnZbpBLzVVzbtp8xTYHcxhdwHEKTokkBBz7zeCzOXCDM7okr phwZXKZrvBcN8slvkzH0H1GT6BUWJSMzTCXu3s2qXdOXj+EgF99k8+iw6lDbpkw= X-Google-Smtp-Source: AGHT+IEOXpDpThrdKOVlBypaulfSggFh0Ut7W12vTBroojXEFSbngpdruMxSeECIgAtuhvzsgB6Geg== X-Received: by 2002:a92:cdab:0:b0:375:dc39:cfd2 with SMTP id e9e14a558f8ab-39f6d729cf6mr123195425ab.11.1725550265308; Thu, 05 Sep 2024 08:31:05 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-39f3af97494sm42365145ab.12.2024.09.05.08.31.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 08:31:04 -0700 (PDT) Message-ID: Date: Thu, 5 Sep 2024 09:31:04 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kunit: Fix missing kerneldoc comment To: David Gow , Brendan Higgins , Rae Moar , Kees Cook , Maxime Ripard , Stephen Rothwell Cc: linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Shuah Khan References: <20240905024757.3600609-1-davidgow@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240905024757.3600609-1-davidgow@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/4/24 20:47, David Gow wrote: > Add a missing kerneldoc comment for the 'test' test context parameter, > fixing the following warning: > > include/kunit/test.h:492: warning: Function parameter or struct member 'test' not described in 'kunit_kfree_const' > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/lkml/20240827160631.67e121ed@canb.auug.org.au/ > Fixes: f2c6dbd22017 ("kunit: Device wrappers should also manage driver name") > Signed-off-by: David Gow > --- > include/kunit/test.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/kunit/test.h b/include/kunit/test.h > index 5ac237c949a0..34b71e42fb10 100644 > --- a/include/kunit/test.h > +++ b/include/kunit/test.h > @@ -484,6 +484,7 @@ static inline void *kunit_kcalloc(struct kunit *test, size_t n, size_t size, gfp > > /** > * kunit_kfree_const() - conditionally free test managed memory > + * @test: The test context object. > * @x: pointer to the memory > * > * Calls kunit_kfree() only if @x is not in .rodata section. David, I sent PR for 6.11-rc7 for the following since it is a critical fix. kunit: Device wrappers should also manage driver name I will take this in once the pr clears applying for 6.12-rc1 thanks, -- Shuah