From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291DFEB64DC for ; Fri, 14 Jul 2023 16:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236050AbjGNQVY (ORCPT ); Fri, 14 Jul 2023 12:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235803AbjGNQVX (ORCPT ); Fri, 14 Jul 2023 12:21:23 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E89D211F for ; Fri, 14 Jul 2023 09:21:22 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id ca18e2360f4ac-780c89d1998so15212839f.1 for ; Fri, 14 Jul 2023 09:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1689351682; x=1689956482; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A/cGtvz8XeWSeI/2ga1OjJQj7bUnENfy64USXIaMRls=; b=RTwPA+NsI6EAvbf0dITS+kJ/8I1AiDxT76aDhGrwVCcUXQHiHHE4v6UFSNUq+aSCGz ToMxIEC7pWGZ+ZkD9fJRjfauM1HZR7/7FeFewmmlGFuMG/RV7V2idZaUWL/l5TVTJhye aU3ntOHO9Kgu0L7KelkSP4IN/giRFc4qwLS5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689351682; x=1689956482; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A/cGtvz8XeWSeI/2ga1OjJQj7bUnENfy64USXIaMRls=; b=aguOK13iiG5tXghwQntKmue2X5ncy4qEqNrnWhiSQYcj5y/IONO1Qen8ZDJzJjXm/e 5LHaGztIpqowVertD5e6OBevx9k11VIT+HZ9x2q057CLn5rhZqhml5Bx1iaIrPUpYXFv Z1yL+cBiVX1JgU3KCb21TIzCeqOnrqbLVZYdlS2koQYqBZCn8CA7fI3tbvZvCgZVfgBm TD68PAwbRDxMyVrlgErPpqnaFUraFh2vznHe5K3Gmr1R2FCANAp563hfyxGwd55hV2jQ tdwB9ffszOoldq93MCA7TvFxyRr0fIwg40n2DH+OMUkOTGatJEbQlll/vklUgR9c6q1e 9zww== X-Gm-Message-State: ABy/qLafQBUK1QzPniNbl6DE2iVzsOmkG7cZ3n8apuug8HFAF4zeUGlb 6dWUa5GlKHD7n9c7mZCK8GIwjg== X-Google-Smtp-Source: APBJJlErVRJu0xQzt35AjSZhJIyGKrlyeOor51Wp+cBkXt8k2AEbxMVRN9RtunAybX6H+lLgyy/vbQ== X-Received: by 2002:a05:6602:3ce:b0:780:c6bb:ad8d with SMTP id g14-20020a05660203ce00b00780c6bbad8dmr5651673iov.0.1689351681771; Fri, 14 Jul 2023 09:21:21 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id f9-20020a056602038900b007862a536f21sm2745024iov.14.2023.07.14.09.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 09:21:21 -0700 (PDT) Message-ID: Date: Fri, 14 Jul 2023 10:21:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] selftests: prctl: Add new prctl test for PR_SET_NAME To: Osama Muhammad Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20230607153600.15816-1-osmtendev@gmail.com> <3c03e28b-8006-a4ac-30bc-6aaf83ccb5d5@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 6/26/23 12:36, Osama Muhammad wrote: > Hi Shuah, > > Any feedback on this patch?. > > Thanks, > Osama > > Please don't top post when you are responding on kernel mailing lists. It gets very difficult to follow the comments in the email thread. > On Sat, 17 Jun 2023 at 18:01, Osama Muhammad wrote: >> >> Hi, >> >> Yes, I did install the latest kernel headers and TASK_COMM_LEN is not >> accessible in userspace. >> >> I looked into the test which uses TASK_COMM_LEN but the test defines >> it in its own header file. >> >> Example: https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13 bfp test does things differently because its dependencies on run-time environment. >> >> TASK_COMM_LEN is defined in include/linux/sched.h, but this header >> file is not exposed to userspace. Correct. you can include linux/sched.h like other tests do Take a look at tools/testing/selftests/clone3 thanks, -- Shuah