From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 190EBECE58D for ; Mon, 7 Oct 2019 14:43:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E24E521721 for ; Mon, 7 Oct 2019 14:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570459380; bh=8a9ttxrtf8XQAHoqUXfvVNJTnrKk2ig330NCAHu4lg8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=D3S9LL+PGcXcnTkChNZ1cilc/GaQxndq3NE6T3PQgeRYAE6JeOsQ37arX3lkms0Lx MZNrw4NYqdfMWUG4od6XG3zWSav1F0WrDd9BdrTJSyhPAeMtDKrj1cq0tb5lmJd3JA VNHWiLQpULmE3KxqYG93FEy3Ngahxyj0Kw8KITRo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbfJGOmz (ORCPT ); Mon, 7 Oct 2019 10:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:54918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727745AbfJGOmz (ORCPT ); Mon, 7 Oct 2019 10:42:55 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 652F821655; Mon, 7 Oct 2019 14:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570459374; bh=8a9ttxrtf8XQAHoqUXfvVNJTnrKk2ig330NCAHu4lg8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AoB6OsaRPmZtmsSo+lnAiCXKXpAVYnRxoGldWXC/BBHobSDS+krxcX7IrlOfGHyrA TxYbr+Z5YnGt6XoXu3UMvJaolTAbaKL0uQsfA2rKEiZhsD8DybbBoZ3r44PxiMr/G5 2Q6UI0fo3E2C4VIFC/24/CxuC6cNzrzr3VHDshCo= Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework To: Brendan Higgins , Linus Torvalds Cc: "Theodore Y. Ts'o" , Frank Rowand , Greg Kroah-Hartman , Josh Poimboeuf , Kees Cook , Kieran Bingham , Luis Chamberlain , Peter Zijlstra , Rob Herring , Stephen Boyd , Masahiro Yamada , devicetree , dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel , Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , "Bird, Timothy" , Amir Goldstein , Dan Carpenter , Daniel Vetter , Jeff Dike , Joel Stanley , Julia Lawall , Kevin Hilman , Knut Omang , Logan Gunthorpe , Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, shuah References: <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> <20191004232955.GC12012@mit.edu> <63e59b0b-b51e-01f4-6359-a134a1f903fd@kernel.org> <544bdfcb-fb35-5008-ec94-8d404a08fd14@kernel.org> <20191006165436.GA29585@mit.edu> From: shuah Message-ID: Date: Mon, 7 Oct 2019 08:42:36 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 10/7/19 2:40 AM, Brendan Higgins wrote: > On Sun, Oct 6, 2019 at 10:18 AM Linus Torvalds > wrote: >> >> On Sun, Oct 6, 2019 at 9:55 AM Theodore Y. Ts'o wrote: >>> >>> Well, one thing we *can* do is if (a) if we can create a kselftest >>> branch which we know is stable and won't change, and (b) we can get >>> assurances that Linus *will* accept that branch during the next merge >>> window, those subsystems which want to use kself test can simply pull >>> it into their tree. >> >> Yes. >> >> At the same time, I don't think it needs to be even that fancy. Even >> if it's not a stable branch that gets shared between different >> developers, it would be good to just have people do a "let's try this" >> throw-away branch to use the kunit functionality and verify that >> "yeah, this is fairly convenient for ext4". >> >> It doesn't have to be merged in that form, but just confirmation that >> the infrastructure is helpful before it gets merged would be good. > > I thought we already had done this satisfactorily. > Adding a couple more tests will only help in the long run. The idea is to see can this help > We have one proof-of-concept test in the branch in the kselftest repo > (proc sysctl test) that went out in the pull request, and we also had > some other tests that were not in the pull request (there is the ext4 > timestamp stuff mentioned above, and we also had one against the list > data structure), which we were planning on sending out for review once > Shuah's pull request was accepted. I know the apparmor people also > wrote some tests that they said were useful; however, I have not > coordinated with them on upstreaming their tests. I know of some other > people who are using it, but I don't think the tests are as far along > for upstreaming. > Maybe that is a good start. To get the tests that are already in use and get them in shape for upstream. > The point is: I thought we had plenty of signal that KUnit would be > useful to have merged into the mainline kernel. I thought the only > reason it was rejected for 5.4 was due to the directory name issue > combined with bad timing. > That is probably the initial thought. However, it makes perfect sense to add a couple of tests in. We have a few weeks anyway and it gives us more confidence on kunit. I already have a branch that is in linux-next and it just has kunit in it and I will rebase it to 5.4-rc1. https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=test Let's use that for kunit work for 5.5. I won't add any kselftest patches to it and keep it dedicated for kunit work. When tests are ready for upstream, I can keep adding them to this branch. thanks, -- Shuah