From: Matthieu Baerts <matttbe@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, ncardwell@google.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two imports
Date: Thu, 12 Sep 2024 13:22:58 +0200 [thread overview]
Message-ID: <ed54ad21-4a5b-4bbb-8f16-22fbfe1bd738@kernel.org> (raw)
In-Reply-To: <20240912005317.1253001-1-willemdebruijn.kernel@gmail.com>
Hi Willem,
On 12/09/2024 02:52, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> 1/3: run in nets, as discussed, and add missing CONFIGs
> 2/3: import tcp/zerocopy
> 3/3: import tcp/slow_start
Thank you for the v2. This new version looks good to me:
Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
I didn't pay too much attention to the new tests, because they look
good, heavily tested I suppose, and I guess the goal is not to diverge
from the original ones for the moment. Still, please note that the CI
reported some timing issues with tcp_zerocopy_closed.pkt when using a
debug kernel config, e.g.
> tcp_zerocopy_closed.pkt:22: timing error: expected system call return at 0.100596 sec but happened at 0.109564 sec; tolerance 0.004000 sec
https://netdev.bots.linux.dev/contest.html?executor=vmksft-packetdrill-dbg&test=tcp-zerocopy-closed-pkt
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-09-12 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 0:52 [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two imports Willem de Bruijn
2024-09-12 0:52 ` [PATCH net-next v2 1/3] selftests/net: packetdrill: run in netns and expand config Willem de Bruijn
2024-09-12 0:52 ` [PATCH net-next v2 2/3] selftests/net: packetdrill: import tcp/zerocopy Willem de Bruijn
2024-09-12 0:52 ` [PATCH net-next v2 3/3] selftests/net: packetdrill: import tcp/slow_start Willem de Bruijn
2024-09-12 11:22 ` Matthieu Baerts [this message]
2024-09-12 12:10 ` [PATCH net-next v2 0/3] selftests/net: packetdrill: netns and two imports Willem de Bruijn
2024-09-16 16:48 ` Stanislav Fomichev
2024-09-16 20:54 ` Willem de Bruijn
2024-09-13 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed54ad21-4a5b-4bbb-8f16-22fbfe1bd738@kernel.org \
--to=matttbe@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox