From: Reinette Chatre <reinette.chatre@intel.com>
To: Peter Newman <peternewman@google.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: Shuah Khan <shuah@kernel.org>,
Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<eranian@google.com>
Subject: Re: [PATCH] selftests/resctrl: Use correct exit code when tests fail
Date: Fri, 17 Mar 2023 10:49:53 -0700 [thread overview]
Message-ID: <ef0ff486-afed-5b3b-34af-0b8a7c5ff5b3@intel.com> (raw)
In-Reply-To: <20230309145757.2280518-1-peternewman@google.com>
Hi Peter,
On 3/9/2023 6:57 AM, Peter Newman wrote:
> Use ksft_finished() after running tests so that resctrl_tests doesn't
> return exit code 0 when tests fail.
>
> Consequently, report the MBA and MBM tests as skipped when running on
> non-Intel hardware, otherwise resctrl_tests will exit with a failure
> code.
>
> Signed-off-by: Peter Newman <peternewman@google.com>
> ---
Thank you very much.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
prev parent reply other threads:[~2023-03-17 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 14:57 [PATCH] selftests/resctrl: Use correct exit code when tests fail Peter Newman
2023-03-15 1:25 ` Shaopeng Tan (Fujitsu)
2023-03-17 17:49 ` Reinette Chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0ff486-afed-5b3b-34af-0b8a7c5ff5b3@intel.com \
--to=reinette.chatre@intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=peternewman@google.com \
--cc=shuah@kernel.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox