From: Eduard Zingerman <eddyz87@gmail.com>
To: Geliang Tang <geliang@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Geliang Tang <tanggeliang@kylinos.cn>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 4/6] selftests/bpf: Null checks for link in bpf_tcp_ca
Date: Mon, 08 Jul 2024 12:42:21 -0700 [thread overview]
Message-ID: <ef98da9d2a4865e6254e1ec9ab57636dfd326f10.camel@gmail.com> (raw)
In-Reply-To: <06755f462ddb7bc9f734f105e18c1d77c03811cb.1720146231.git.tanggeliang@kylinos.cn>
On Fri, 2024-07-05 at 10:38 +0800, Geliang Tang wrote:
[...]
I think that this patch is an improvement independent of the patch-set.
Please submit it separately.
> .../selftests/bpf/prog_tests/bpf_tcp_ca.c | 16 ++++++++++++----
[...]
> @@ -489,6 +494,7 @@ static void test_mixed_links(void)
> ASSERT_ERR(err, "update_map");
>
> bpf_link__destroy(link);
> +err:
Nit: there are two links in this test, but ASSERT_OK_PTR is added only
for a single one. Also note that bpf_link__destroy(NULL) works
just fine, so it is possible to initialize links as NULL and make
a jump to cleanup block w/o peeking exact position within that block.
> bpf_link__destroy(link_nl);
> tcp_ca_update__destroy(skel);
> }
[...]
next prev parent reply other threads:[~2024-07-08 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 2:38 [PATCH bpf-next v2 0/6] skip ENOTSUPP BPF selftests Geliang Tang
2024-07-05 2:38 ` [PATCH bpf-next v2 1/6] selftests/bpf: Define ENOTSUPP in testing_helpers.h Geliang Tang
2024-07-05 2:38 ` [PATCH bpf-next v2 2/6] selftests/bpf: Skip ENOTSUPP in ASSERT_OK Geliang Tang
2024-07-08 18:54 ` Andrii Nakryiko
2024-07-08 19:47 ` Eduard Zingerman
2024-07-05 2:38 ` [PATCH bpf-next v2 3/6] selftests/bpf: Use ASSERT_OK to skip ENOTSUPP Geliang Tang
2024-07-05 2:38 ` [PATCH bpf-next v2 4/6] selftests/bpf: Null checks for link in bpf_tcp_ca Geliang Tang
2024-07-08 19:42 ` Eduard Zingerman [this message]
2024-07-10 2:58 ` Geliang Tang
2024-07-05 2:38 ` [PATCH bpf-next v2 5/6] selftests/bpf: Skip ENOTSUPP in ASSERT_OK_PTR Geliang Tang
2024-07-05 2:38 ` [PATCH bpf-next v2 6/6] selftests/bpf: Skip ENOTSUPP in ASSERT_GE Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef98da9d2a4865e6254e1ec9ab57636dfd326f10.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=geliang@kernel.org \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=tanggeliang@kylinos.cn \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox