From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 589EA74421 for ; Mon, 30 Sep 2024 20:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727728326; cv=none; b=X7G2eXSIv1vZ1Kbujkx0aB2+hp3HLW+X4I63WjdHzfJy+KrxQnWKs1deTdweO3x8KmSaiSR0fIohB/JyP2pJZYFYHnYNf8+kmNNxtAYBylivtpbLnhY1Jpf8Izj49F8cdZ9B+tLKWpcIlnQoEvEAV7jHd0RWhbaGrqWdnDutPJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727728326; c=relaxed/simple; bh=iuTBkTsVyUwHG/0VX7MtzJpflCWh6jClaP5eVt/7IPQ=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=i5MlHg68hkv6WE68wrWD9jn97XMPmbTwZ6CEX1eVtIW/rJyeTZYKaDQVJzQIB0KlGqhVfYU5UG7cYyyMk69YI67zCPOJh+8PmggqPCqoH02MXwpuAPQoBRBm+iIW2ztF5nyGTdLih/fjEFELXExpV9+mh23P6AwlRPDQ0KmXnTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dg9blAMH; arc=none smtp.client-ip=209.85.166.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dg9blAMH" Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-8323b555ae2so239754639f.2 for ; Mon, 30 Sep 2024 13:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727728323; x=1728333123; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=fh9PH2Jop7KznotYQEt9VOPK+AuZOwXiP4v5Ug8+hPc=; b=dg9blAMHXjsDSvMjGp6PaflU7q+fvbVJFchBu+h2kJ5zzhwFA6VKzGRgwW5BNgTaC4 mEea/B8VqPC5bhm4pSQ4YmCRY+GNPDsr47Y9v/SClmP8JmA4d7rJNqgGNfohN+ejLqVd PXTdKOxrDZdBDRZPqR0HJlafjB7RbAEuFI+og= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727728323; x=1728333123; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fh9PH2Jop7KznotYQEt9VOPK+AuZOwXiP4v5Ug8+hPc=; b=BT7JniMKAuTKeJaki7mo6JHbcAUVqK+10uX4a8ith95vvxqi0IZTzmSCD3wWnhdJnw GnjMI1U4QWfy38tuxQyoHerb06SZx+WnzkcHPVtlVWZtJ11LVHFoU1RlhvXXj92oK+6k salJpC0J+uZJ8HxAJf7shaenA65mSLpX/bY+5s6hPRftLHXLFFvRKfCPuOt2l/pYCztG bwHrFJPGWojk4x+97Mxtwh0EdyltJdtH9aDgq4W6Omk+DCjTMrnVoLli55dYJ3lMbeSb YQ1oOlEl/0TBDqEdrucPw7sI+nmhAdfSCDKLYxBY6R16IbNYcoEvJTxb8focAZmYP0zG wVLA== X-Forwarded-Encrypted: i=1; AJvYcCVOrPEH1w7pkW+L4JOsj+kAeuwVEA/RE3gtHuQ7DKWL8mTh9TnxBDFrv8bVrSp3dIIpjr4NbN+IWZm3QSBDbdQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz5cfGmkIQqnxxaxzDF+ixV3ebLXiuZAT6Qyu0BkEl7TP0589Y JdIotdV5KoN/Qb9b7NFXXITre63tEfeIcogil6/KjFdQawlXsjJWL5m60fg6RoU= X-Google-Smtp-Source: AGHT+IHiJKMaCXtddQeMdqbzlj9+mgu41HkyhLDB0xfNP3HkFbQViAqxH4ZR5Vmwe1Tup1wyJLXA6g== X-Received: by 2002:a05:6602:1653:b0:82c:e8d2:f86b with SMTP id ca18e2360f4ac-834932796c6mr1072841339f.14.1727728323394; Mon, 30 Sep 2024 13:32:03 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d88884a431sm2269417173.64.2024.09.30.13.32.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 13:32:03 -0700 (PDT) Message-ID: Date: Mon, 30 Sep 2024 14:32:02 -0600 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: update core.c To: =?UTF-8?B?T2thbiBUw7xtw7xrbMO8?= , shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Kees Cook , Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/29/24 16:40, Okan Tümüklü wrote: > 1:The control flow was simplified by using else if statements instead of goto structure. > > 2:Error conditions are handled more clearly. > > 3:The device_unlock call at the end of the function is guaranteed in all cases. > > Github request : https://github.com/torvalds/linux/pull/967 Please send patches for these changes. Refer to submitting patches document in the kernel repo. thanks, -- Shuah