From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C67012D12E4 for ; Fri, 29 Aug 2025 11:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756468653; cv=none; b=OurTlTkg9RgJLf1A0qBJ9UMSRIwCzQsSC1EqApvvXiMKAGupRyza9tsNpC1sg+fJXcDkqWu0JX8PZXt2YpD/B6LihJ6V0WQn0yU0ufHO94/+P3sqCTbIouHyKFNM8JXDw1abqb5ezMIjTg0JASifc+KMSS3XeJqyPm0UoG8sHIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756468653; c=relaxed/simple; bh=5Lp4Ng+SdyxZXZ9PSEkbl/hklhBiTxJ5cZJWR1+SKa0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TG/dVkQO4N3pEyMb76zGMt9WXfxjVbu32Gi+z9Z6b4N+X/4FH0Udtq5qHgTp8u07gcFsrjPSnduLKrCtqgXukizLNzEfn+GZbj9BK0112RdTenf4EgUc6YBtEr3H1ksGCKJU9ng7srdcz4BjmrU3VFAZHPOMj6gxenfU1BgvJQ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WNUDebRf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WNUDebRf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756468649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hoDokfG1MQmzSDgEaptCicCjaaQpWxY2iqh8txE4sWo=; b=WNUDebRfNSHeOMmvbUJuY8y3p3G32ZuitizzR43nZsBipDvV/JarfsvJc3YXwMMhIFPhVf eRjZqcrHAcrTLu5NM1nC0CeX86hlF/kvQ+CR+GPH2pj6nuyLLbuYJ6VcgivC5g1KzL8cVy cKd0aUU/b/MmK+K8NS6xTv4maVBnCPg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-v6Ikf1G6Mcm96pooCTJLRw-1; Fri, 29 Aug 2025 07:57:27 -0400 X-MC-Unique: v6Ikf1G6Mcm96pooCTJLRw-1 X-Mimecast-MFC-AGG-ID: v6Ikf1G6Mcm96pooCTJLRw_1756468646 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b7d84d8a0so4128855e9.1 for ; Fri, 29 Aug 2025 04:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756468646; x=1757073446; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hoDokfG1MQmzSDgEaptCicCjaaQpWxY2iqh8txE4sWo=; b=LJ91z23La5B1QC7yxLLd0R9JphwB44dJCY74S7S3FmE3S3k4ruNtsrDBUGFts2xAPQ 3LZml9jf+k/d9E91mGvoJq4xL/FkJV9/7vc95JcPZ3R2C4N46lx+NDe7dwiK38t5ec/j jTdwT4ersfv0d5t6BDiV4ZY8K3T9Px+M7WqHeaRb+le47KdrTrTdAmsoXlM9sE0S9nXn w0tBm9yZHRw2RpxF1U73akx/T1E9vvxWkiTnIFr7o5Wl386mu6EBXypQ5xlWxQs/rt4c u8GaaznZdrLst/jSRL0SKTPNXy64ZMpSQRstgLv+TGcJj9pMxz68E4wpGnjHdOJjZ7Sj Qmuw== X-Forwarded-Encrypted: i=1; AJvYcCUky2dlHYCGcjNiKQo84gj41T2L7v0hAkG2YdrtzDyHZrSEM3Sqqq2gp12W/fPZDMswWMbbIxq8bd1Klhwojls=@vger.kernel.org X-Gm-Message-State: AOJu0YwYaD1YURGLM9cRFL5TNPip1I31Bu80thRg+QCzufCun4vJtYm4 6tMM45RBtVkzh+X3jkyoTICvfNNPVZz5dzRGS7oeAgzca1YQEnoU70SgKAobVqwau8uK10XRnL3 gCCLz4pmiqNsolHYwrvH5AcQLiMws6KjkFFTUNOva1F0OGcknoQHkgjzsf0EpKUlQRU7H5w== X-Gm-Gg: ASbGncsak6lM3g42MnN36z0Ma1lJn2pcUCwlI6jKlWjVEXJUq+dQgRCy2RbynQj1WJQ B+5eMvvJFq8wDfpaSkfu8nNAdk6lVhyHiNJ8I3MpM1PmLA258DrkVie8JOS0NrhsFhHc9tLMLMB z6HmNgVlWYkpNyiynKWV4EJ0hAfvxumEbb/cy9WyQzhrfj6EREKBw2sqSyYHjtYvF5fBva1wkOx JbFguCV8DbaqmqgqqMrWJVKpb6eUWzcDzubQ+1IzI8Mt2niCYmFjKsBWfO5P13Om/VnyGYNxND1 QktVZlDVm2M2TepsfN8Tuge/e2PTJrAhvVhwhIPCHMRDX+bI9ztFCcdwIFzY5YMdYRf1A6FjqoL UYQ9XtQ2kikllxATr3HDRO7HQvXCaSWac3ZTGUdmlJhmRPonQdJbHdDFyzkLIlLM= X-Received: by 2002:a05:600c:348d:b0:45b:80ab:3359 with SMTP id 5b1f17b1804b1-45b80ab35acmr15394725e9.0.1756468645766; Fri, 29 Aug 2025 04:57:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG95+220rsAfy23meKWNy4rnKbzYvRZ5zPoY4wdVrGBgRqoKPVywzJTjIuqBTuNai4wkDfQaw== X-Received: by 2002:a05:600c:348d:b0:45b:80ab:3359 with SMTP id 5b1f17b1804b1-45b80ab35acmr15394435e9.0.1756468645290; Fri, 29 Aug 2025 04:57:25 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1d:100:4f8e:bb13:c3c7:f854? (p200300d82f1d01004f8ebb13c3c7f854.dip0.t-ipconnect.de. [2003:d8:2f1d:100:4f8e:bb13:c3c7:f854]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f0c6b99sm116739135e9.4.2025.08.29.04.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Aug 2025 04:57:24 -0700 (PDT) Message-ID: Date: Fri, 29 Aug 2025 13:57:22 +0200 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/36] mm: limit folio/compound page sizes in problematic kernel configs To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, Zi Yan , "Mike Rapoport (Microsoft)" , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Marco Elver , Marek Szyprowski , Michal Hocko , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Robin Murphy , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org References: <20250827220141.262669-1-david@redhat.com> <20250827220141.262669-12-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.08.25 17:10, Lorenzo Stoakes wrote: > On Thu, Aug 28, 2025 at 12:01:15AM +0200, David Hildenbrand wrote: >> Let's limit the maximum folio size in problematic kernel config where >> the memmap is allocated per memory section (SPARSEMEM without >> SPARSEMEM_VMEMMAP) to a single memory section. >> >> Currently, only a single architectures supports ARCH_HAS_GIGANTIC_PAGE >> but not SPARSEMEM_VMEMMAP: sh. >> >> Fortunately, the biggest hugetlb size sh supports is 64 MiB >> (HUGETLB_PAGE_SIZE_64MB) and the section size is at least 64 MiB >> (SECTION_SIZE_BITS == 26), so their use case is not degraded. >> >> As folios and memory sections are naturally aligned to their order-2 size >> in memory, consequently a single folio can no longer span multiple memory >> sections on these problematic kernel configs. >> >> nth_page() is no longer required when operating within a single compound >> page / folio. >> >> Reviewed-by: Zi Yan >> Acked-by: Mike Rapoport (Microsoft) >> Signed-off-by: David Hildenbrand > > Realy great comments, like this! > > I wonder if we could have this be part of the first patch where you fiddle > with MAX_FOLIO_ORDER etc. but not a big deal. I think it belongs into this patch where we actually impose the restrictions. [...] >> +/* >> + * Only pages within a single memory section are guaranteed to be >> + * contiguous. By limiting folios to a single memory section, all folio >> + * pages are guaranteed to be contiguous. >> + */ >> +#define MAX_FOLIO_ORDER PFN_SECTION_SHIFT > > Hmmm, was this implicit before somehow? I mean surely by the fact as you say > that physical contiguity would not otherwise be guaranteed :)) Well, my patches until this point made sure that any attempt to use a larger folio would fail in a way that we could spot now if there is any offender. That is why before this change, nth_page() was required within a folio. Hope that clarifies it, thanks! -- Cheers David / dhildenb