From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDE2C31E45 for ; Thu, 13 Jun 2019 15:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2982207E0 for ; Thu, 13 Jun 2019 15:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560438371; bh=7OQwG+702F83sAlyNtbM+xJYZmjcRDOB9gr9GLwbm/c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=05X1uOb+AOdGHlGPxcBVcqv5w19KmNOmmx8l8Gt10I7D0KqCQm4tTCWx+PQVnF/t6 MnlJu1uLfAJxX9aaN7dzs1mTlizJ+AdG7gBgG2KOaUpLnVZio88WAODRcNzVDRE3st GSaaHGd5605XH+V1nE7J1Iz+B3q8RzaWT0qLOxzw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732428AbfFMPGK (ORCPT ); Thu, 13 Jun 2019 11:06:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:43144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732422AbfFMOKW (ORCPT ); Thu, 13 Jun 2019 10:10:22 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6256A2082C; Thu, 13 Jun 2019 14:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560435020; bh=7OQwG+702F83sAlyNtbM+xJYZmjcRDOB9gr9GLwbm/c=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fy827eMPNUMVo1nmLnXJA6nqyasdum9lUWVDJRjDXrYqe7HHkDyvSp0qpAXeq9iGs qwXrr3QI4wouB6/NX8mAR6f8dLdDEwwYJ2Kww5cZLXNaW5kf3RcknFoqNYwELrplon ch0MUmzKkKOmEuUmSWfqdEl0z2XnxEGEz56vDWTM= Subject: Re: kselftest build broken? To: =?UTF-8?Q?Daniel_D=c3=adaz?= Cc: Dmitry Vyukov , Naresh Kamboju , Anders Roxell , "open list:KERNEL SELFTEST FRAMEWORK" , shuah References: <54bc80f8-71aa-1c04-5908-01923247832e@kernel.org> <6d5e0484-4dbc-d122-1ae4-9cce44c2d668@kernel.org> <1e2cc74d-a6c2-0a73-ede5-c72df28e96b2@kernel.org> <37e5e069-076d-9833-9eab-51c507fbbe2f@kernel.org> From: shuah Message-ID: Date: Thu, 13 Jun 2019 08:10:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 6/12/19 3:12 PM, Daniel Díaz wrote: > Hello! > > On Wed, 12 Jun 2019 at 14:32, shuah wrote: >> On 6/12/19 12:29 PM, Dmitry Vyukov wrote: > [...] >>> 1. You suggested to install a bunch of packages. That helped to some >>> degree. Is there a way to figure out what packages one needs to >>> install to build the tests other than asking you? >> >> I have to go through discovery at times when new tests get added. I >> consider this a part of being a open source developer figuring out >> dependencies for compiling and running. I don't have a magic answer >> for you and there is no way to make sure all dependencies will be >> documented. > > This is something we, as users of Kselftests, would very much like to > see improved. We also go by trial-and-error finding out what is > missing, but keeping up with the new tests or subsystems is often > difficult and tend to remain broken (in usage) for some time, until we > have the resources to look into that and fix it. The config fragments > is an excellent example of how the test developers and the framework > complement each other to make things work. Even documenting > dependencies would go a long way, as a starting point, but I do > believe that the test writers should do that and not the users go > figure out what all is needed to run their tests. > > Maybe a precheck() on the tests in order to ensure that the needed > binaries are around? > Right. Take a look at x86 test Makefile - it handles that. Tests can handle these in their Makefile - not at run-time. I will be happy to take patches similar to the checks x86 does. These shouldn't fail the kselftest build and print out dependencies. This way users can go install them. > For what it's worth, this is the list of run-time dependencies package > for OpenEmbedded: bash bc ethtool fuse-utils iproute2 iproute2-tc > iputils-ping iputils-ping6 ncurses perl sudo python3-argparse > python3-datetime python3-json python3-pprint python3-subprocess > util-linux-uuidgen cpupower glibc-utils. We are probably missing a > few. > Sure see above. thanks, -- Shuah