From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAB4AC433FE for ; Thu, 10 Nov 2022 01:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbiKJBpL (ORCPT ); Wed, 9 Nov 2022 20:45:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232215AbiKJBo6 (ORCPT ); Wed, 9 Nov 2022 20:44:58 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D03E529CAB for ; Wed, 9 Nov 2022 17:44:55 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id d123so252159iof.7 for ; Wed, 09 Nov 2022 17:44:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3lBtbVkZS1O7YbzecaVkeQEW2VLlO/W425Vba7t3Ot0=; b=HFXqzbHSbg052lZLmDmPZwoSQW8Tcdiy9UvPmwrDN031z+6KJT93GpalKkBT25HFk2 s8o0+MlC1yWdSmfaZX72pgxEfuCum3Zw2+wGp3G2oBXK8oVeW69xvVnOoHnnSVeMkj/q 8pm6JgGR7V6LGOP9ntA2wb6y+LN0qyI2LSmok= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3lBtbVkZS1O7YbzecaVkeQEW2VLlO/W425Vba7t3Ot0=; b=qb1Mr869Db0nY1/0pR8vKxNMsLlc3gaeXWe5xoDERso+BA30mfzhuc79Iojq1Qaje5 NAxIlXXPnERWeP8hmNXJg7nLauBTirqjtTrtWhiSSeclV6WvWUn1j8pYOIOzDz+zmFt5 C7Q4gpNv+20NrAqiIiHBCT5NJo0UqM2lEgwS8f5w+1jJxx+efLWh5LMWELQPhXK4mB47 RL2NwjDz3CBMcN4mTpIbvDMFDNAY8aqmGf0/tfBwTQ3H9QnsJNbA+gjfw0v1wQqjScmL Ku79rUJEfw1HVizevfMfC9ZgfUn1l9RTXTdUJpPbSJDt2HEKJ1/a9Zl+wnqar1L2SXVL gHPA== X-Gm-Message-State: ACrzQf2P/A46V6+gAKag7tF7BQjMJ/zUnMaAAeg5eG7nfJI+5k1gxr/o Tmd+ALmKOfyhwHR0lMz1ITdDLw== X-Google-Smtp-Source: AMsMyM4N+ShT65zrwNwM1pqouojkO8Zx8uSOZ0T/e/+0A1Bhu96VM5qrkV9dQ1GG690mLjuMHerayQ== X-Received: by 2002:a02:6062:0:b0:375:631f:111e with SMTP id d34-20020a026062000000b00375631f111emr2392394jaf.123.1668044695147; Wed, 09 Nov 2022 17:44:55 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id d12-20020a92d78c000000b003002947096asm5366733iln.65.2022.11.09.17.44.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 17:44:54 -0800 (PST) Message-ID: Date: Wed, 9 Nov 2022 18:44:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2 1/2] selftests: proc: Fix proc-empty-vm build error on non x86_64 Content-Language: en-US To: Andrew Morton , Punit Agrawal Cc: shuah@kernel.org, adobriyan@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20221109221104.1797802-1-punit.agrawal@bytedance.com> <20221109160243.0db030ca1cbae5f180af3855@linux-foundation.org> From: Shuah Khan In-Reply-To: <20221109160243.0db030ca1cbae5f180af3855@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 11/9/22 17:02, Andrew Morton wrote: > On Wed, 9 Nov 2022 22:11:03 +0000 Punit Agrawal wrote: > >> The proc-empty-vm test is implemented for x86_64 and fails to build >> for other architectures. Rather then emitting a compiler error it >> would be preferable to only build the test on supported architectures. > > Why does it fail? What would be involved in making it available > on other architectures? > I have the same question and also don't like adding TEST_GEN_PROGS_x86_64 Please see my comments on the two patches regarding this. thanks, -- Shuah