Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Yuan Tan <tanyuan@tinylab.org>
Cc: w@1wt.eu, falcon@tinylab.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase
Date: Mon, 31 Jul 2023 08:13:15 +0200	[thread overview]
Message-ID: <f30d3620-cdeb-45be-ba2b-2298a478c5bd@t-8ch.de> (raw)
In-Reply-To: <cover.1690733545.git.tanyuan@tinylab.org>

Hi Yuan!

On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> Thanks to your advice and I really learned a lot from it.
> 
> V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
> case.

Thanks!

I have some more comments for the patches.

For new revisions you should also link to the old revision.

> Best regards,
> Yuan Tan
> 
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
> 
>  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
>  tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
>  2 files changed, 59 insertions(+)
> 
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2023-07-31  6:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  5:50 [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase Yuan Tan
2023-07-31  5:50 ` [PATCH v2 1/2] tools/nolibc: add pipe() and pipe2() support Yuan Tan
2023-07-31  6:07   ` Thomas Weißschuh
2023-07-31  6:13   ` Thomas Weißschuh
2023-07-31  5:51 ` [PATCH v2 2/2] selftests/nolibc: add testcase for pipe Yuan Tan
2023-07-31  6:10   ` Thomas Weißschuh
2023-07-31 12:35     ` Yuan Tan
2023-07-31 15:41       ` Thomas Weißschuh
2023-07-31 18:01         ` Yuan Tan
2023-07-31 18:28           ` Thomas Weißschuh
2023-08-01  6:51             ` Yuan Tan
2023-08-01  7:20               ` Thomas Weißschuh
2023-08-01 12:23                 ` Yuan Tan
2023-08-01 14:46                   ` Thomas Weißschuh 
2023-07-31  6:13 ` Thomas Weißschuh [this message]
2023-07-31 11:08   ` [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase Yuan Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f30d3620-cdeb-45be-ba2b-2298a478c5bd@t-8ch.de \
    --to=thomas@t-8ch.de \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=tanyuan@tinylab.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox