Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Waiman Long <llong@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
	Sun Shaojie <sunshaojie@kylinos.cn>,
	Chen Ridong <chenridong@huaweicloud.com>,
	Chen Ridong <chenridong@huawei.com>
Subject: Re: [PATCH cgroup/for-6.20 v4 4/5] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict
Date: Mon, 12 Jan 2026 09:51:28 -0500	[thread overview]
Message-ID: <f33eb2b3-c2f4-48ae-b2cd-67c0fc0b4877@redhat.com> (raw)
In-Reply-To: <2naek52bbrod4wf5dbyq2s3odqswy2urrwzsqxv3ozrtugioaw@sjw5m6gizl33>

On 1/12/26 5:51 AM, Michal Koutný wrote:
> On Sun, Jan 11, 2026 at 11:08:55PM -0500, Waiman Long <longman@redhat.com> wrote:
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> ...
>> @@ -2632,6 +2641,9 @@ Cpuset Interface Files
>>   
>>   	The root cgroup is always a partition root and its state cannot
>>   	be changed.  All other non-root cgroups start out as "member".
>> +	Even though the "cpuset.cpus.exclusive*" control files are not
>> +	present in the root cgroup, they are implicitly the same as
>> +	"cpuset.cpus".
> cpuset.cpus.effective (that one is on root cpuset cg)
>
> (This was likely lost among my v2 comments.)

Sorry, I might have missed this comment of yours. The 
"cpuset.cpus.exclusive" file lists all the CPUs that can be granted to 
its children as exclusive CPUs. The cgroup root is an implicit partition 
root where all its CPUs can be granted to its children whether they are 
online or offline. "cpuset.cpus.effective" OTOH ignores the offline CPUs 
as well as exclusive CPUs that have been passed down to existing 
descendant partition roots so it may differ from the implicit 
"cpuset.cpus.exclusive".

Cheers,
Longman


  reply	other threads:[~2026-01-12 14:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12  4:08 [PATCH cgroup/for-6.20 v4 0/5] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict Waiman Long
2026-01-12  4:08 ` [PATCH cgroup/for-6.20 v4 1/5] cgroup/cpuset: Streamline rm_siblings_excl_cpus() Waiman Long
2026-01-12  4:08 ` [PATCH cgroup/for-6.20 v4 2/5] cgroup/cpuset: Consistently compute effective_xcpus in update_cpumasks_hier() Waiman Long
2026-01-12  4:08 ` [PATCH cgroup/for-6.20 v4 3/5] cgroup/cpuset: Don't fail cpuset.cpus change in v2 Waiman Long
2026-01-12  4:08 ` [PATCH cgroup/for-6.20 v4 4/5] cgroup/cpuset: Don't invalidate sibling partitions on cpuset.cpus conflict Waiman Long
2026-01-12 10:51   ` Michal Koutný
2026-01-12 14:51     ` Waiman Long [this message]
2026-01-12 15:08       ` Michal Koutný
2026-01-12 15:15         ` Waiman Long
2026-01-12 16:02           ` Waiman Long
2026-01-12  4:08 ` [PATCH cgroup/for-6.20 v4 5/5] cgroup/cpuset: Move the v1 empty cpus/mems check to cpuset1_validate_change() Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f33eb2b3-c2f4-48ae-b2cd-67c0fc0b4877@redhat.com \
    --to=llong@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=chenridong@huawei.com \
    --cc=chenridong@huaweicloud.com \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=shuah@kernel.org \
    --cc=sunshaojie@kylinos.cn \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox