From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Lorenzo Stoakes <ljs@kernel.org>, Chen Wandun <chenwandun1@gmail.com>
Cc: akpm@linux-foundation.org, shuah@kernel.org, zokeefe@google.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/khugepaged: fix spurious -EINVAL from sub-PMD MADV_COLLAPSE range
Date: Fri, 8 May 2026 21:29:38 +0200 [thread overview]
Message-ID: <f50cba12-743e-4f68-bff4-d3387b63dde2@kernel.org> (raw)
In-Reply-To: <af30otSSGbPxHbxM@lucifer>
>>
>> In general, LGTM, but see for conflict:
>> https://lore.kernel.org/all/20260409014323.2385982-1-ye.liu@linux.dev/
>
> Please use mm-unstable as a basis for your mm work Chen, this is something you
> need to fix, the patch above has been around for a while and is in
> mm-unstable.
>
> You have patches in mm already so you should know better by now.
>
> But I'm really not sure I'm in favour of this anyway. I'll defer to David but
> this feels useless to me.
I don't enjoy the underflow in the return statement, so I think we should just
clean that up.
--
Cheers,
David
next prev parent reply other threads:[~2026-05-08 19:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 7:05 [PATCH 0/2] mm/khugepaged: fix sub-PMD MADV_COLLAPSE range handling Chen Wandun
2026-05-07 7:05 ` [PATCH 1/2] mm/khugepaged: fix spurious -EINVAL from sub-PMD MADV_COLLAPSE range Chen Wandun
2026-05-08 12:27 ` David Hildenbrand (Arm)
2026-05-08 15:02 ` Lorenzo Stoakes
2026-05-08 15:04 ` Lorenzo Stoakes
2026-05-09 7:53 ` Wandun
2026-05-08 19:29 ` David Hildenbrand (Arm) [this message]
2026-05-09 7:04 ` Wandun
2026-05-09 5:56 ` Wandun
2026-05-07 7:05 ` [PATCH 2/2] selftests/mm: add MADV_COLLAPSE sub-PMD range tests Chen Wandun
2026-05-08 12:23 ` David Hildenbrand (Arm)
2026-05-08 15:03 ` Lorenzo Stoakes
2026-05-09 9:47 ` [PATCH 0/2] mm/khugepaged: fix sub-PMD MADV_COLLAPSE range handling Lance Yang
2026-05-11 2:06 ` Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50cba12-743e-4f68-bff4-d3387b63dde2@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chenwandun1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=shuah@kernel.org \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox