From: Paran Lee <p4ranlee@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Shuah Khan <shuah@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/ftrace: Update comment and clean up
Date: Wed, 15 Mar 2023 13:09:51 +0900 [thread overview]
Message-ID: <f7d58b48-41c6-a77d-2f7d-0df8ea59933e@gmail.com> (raw)
In-Reply-To: <20230313103033.7bb461ef@gandalf.local.home>
2023-03-13 오후 11:30에 Steven Rostedt 이(가) 쓴 글:
> On Sat, 11 Mar 2023 21:41:53 +0900
> paranlee <p4ranlee@gmail.com> wrote:
>
>> Update renamed function comment
>> and clean up indent from 4 space to tab.
>
> This isn't C code, it's a shell script where editors do things differently.
>
> I only care that the file is constant in its indenting.
>
> I won't nack this, but I won't ack it nor take it myself.
>
> -- Steve
Hi Steve, thanks for the code review,
it's nice to me have solid guidelines a tool related script works.
The first thing I noticed was that the a comment where "_do_fork was
changed to kernel_fork" instead of "kernel_clone",
so I fixed that as well.
Would it be better to send that typo fix along with the other fixes?
BR
Paran Lee
next prev parent reply other threads:[~2023-03-15 4:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 12:41 [PATCH] selftests/ftrace: Update comment and clean up paranlee
2023-03-13 14:30 ` Steven Rostedt
2023-03-15 4:09 ` Paran Lee [this message]
2023-03-15 13:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d58b48-41c6-a77d-2f7d-0df8ea59933e@gmail.com \
--to=p4ranlee@gmail.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox