From: Aaron Conole <aconole@redhat.com>
To: Minxi Hou <houminxi@gmail.com>
Cc: netdev@vger.kernel.org, echaudro@redhat.com,
i.maximets@ovn.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
shuah@kernel.org, dev@openvswitch.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 2/2] selftests: openvswitch: add pop_vlan test
Date: Fri, 08 May 2026 10:37:21 -0400 [thread overview]
Message-ID: <f7tzf2aq866.fsf@redhat.com> (raw)
In-Reply-To: <20260508134308.2857449-3-houminxi@gmail.com> (Minxi Hou's message of "Fri, 8 May 2026 21:43:08 +0800")
Minxi Hou <houminxi@gmail.com> writes:
> Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action
> correctly strips 802.1Q VLAN tags from frames.
>
> Test structure:
> - Baseline: untagged forwarding validates basic connectivity.
> - Negative: forward without pop_vlan, tagged frame is invisible
> to ns2 (no VLAN sub-interface), ping fails.
> - Positive: pop_vlan strips tag on forward path, push_vlan
> restores tag on return path, ping succeeds.
>
> Use static ARP entries to avoid VLAN-tagged ARP complexity.
> Rely on ping success/failure for verification -- no tcpdump or
> pcap files needed.
>
> Signed-off-by: Minxi Hou <houminxi@gmail.com>
> ---
There is an issue applying to net-next, so this will need to be rebased
on net-next - likely a conflict from 05416ada37aa4 ("selftests:
openvswitch: add tests for tunnel vport refcounting"). Please wait 24h
before reposting and you can include my review tags in 1/2 and 2/2
Reviewed-by: Aaron Conole <aconole@redhat.com>
prev parent reply other threads:[~2026-05-08 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:43 [PATCH net-next v8 0/2] selftests: openvswitch: add pop_vlan test Minxi Hou
2026-05-08 13:43 ` [PATCH net-next v8 1/2] selftests: openvswitch: add vlan() and encap() flow string parsing Minxi Hou
2026-05-08 14:36 ` Aaron Conole
2026-05-08 13:43 ` [PATCH net-next v8 2/2] selftests: openvswitch: add pop_vlan test Minxi Hou
2026-05-08 14:37 ` Aaron Conole [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7tzf2aq866.fsf@redhat.com \
--to=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=houminxi@gmail.com \
--cc=i.maximets@ovn.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox