From: Randy Dunlap <rdunlap@infradead.org>
To: Taichi Nishimura <awkrail01@gmail.com>,
shuah@kernel.org, andrii@kernel.org, mykolal@fb.com,
ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, davem@davemloft.net, kuba@kernel.org,
hawk@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
trix@redhat.com, ytcoode@gmail.com, deso@posteo.net,
joannelkoong@gmail.com
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] fixed typos on selftests/bpf
Date: Tue, 14 Feb 2023 08:44:02 -0800 [thread overview]
Message-ID: <f8f3e8df-f707-28f3-ab0f-eec21686c940@infradead.org> (raw)
In-Reply-To: <20230214152850.389392-1-awkrail01@gmail.com>
Hi--
On 2/14/23 07:28, Taichi Nishimura wrote:
> I run spell checker and found typos in selftest/bpf/ files.
> Fixed all of the detected typos.
>
> This patch is an extra credit for kselftest task
> in the Linux kernel bug fixing spring unpaid 2023.
>
> Best regards,
> Taichi Nishimura
>
> Signed-off-by: Taichi Nishimura <awkrail01@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c | 2 +-
> tools/testing/selftests/bpf/prog_tests/trampoline_count.c | 2 +-
> tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
> tools/testing/selftests/bpf/progs/dynptr_fail.c | 2 +-
> tools/testing/selftests/bpf/progs/strobemeta.h | 2 +-
> tools/testing/selftests/bpf/progs/test_cls_redirect.c | 4 ++--
> tools/testing/selftests/bpf/progs/test_subprogs.c | 2 +-
> tools/testing/selftests/bpf/progs/test_xdp_vlan.c | 2 +-
> tools/testing/selftests/bpf/test_cpp.cpp | 2 +-
> tools/testing/selftests/bpf/veristat.c | 4 ++--
> 10 files changed, 12 insertions(+), 12 deletions(-)
>
Issues here:
> @@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
> *
> * fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
> *
> - * clang will substitue a costant for sizeof, which allows the verifier
> + * clang will substitute a costant for sizeof, which allows the verifier
constant
> * to track it's value. Based on this, it can figure out the constant
its value.
> * return value, and calling code works while still being "generic" to
> * IPv4 and IPv6.
The other changes look good. Thanks.
After fixing the issues above:
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
next prev parent reply other threads:[~2023-02-14 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 15:28 [PATCH] fixed typos on selftests/bpf Taichi Nishimura
2023-02-14 16:44 ` Randy Dunlap [this message]
2023-02-15 3:21 ` [PATCH v2] " Taichi Nishimura
2023-02-15 3:25 ` Randy Dunlap
2023-02-15 18:21 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f3e8df-f707-28f3-ab0f-eec21686c940@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=awkrail01@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=deso@posteo.net \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=trix@redhat.com \
--cc=yhs@fb.com \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).