From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A542C433B4 for ; Fri, 14 May 2021 19:57:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E58361353 for ; Fri, 14 May 2021 19:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233236AbhENT6g (ORCPT ); Fri, 14 May 2021 15:58:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233134AbhENT6g (ORCPT ); Fri, 14 May 2021 15:58:36 -0400 Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1EE9C061756 for ; Fri, 14 May 2021 12:57:22 -0700 (PDT) Received: by mail-il1-x12a.google.com with SMTP id r5so771519ilb.2 for ; Fri, 14 May 2021 12:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=URzNzA8vwTk8ltn99LExmH9Gj1Z1XVZ/xKYnVSUJ+eY=; b=hgsntZOgovnbfwcq8LAgBDSF+PVAqFk+Ju2ltBGfH5ND1+JSIbu0c6EjXVMN59icok a4GCJC//h3rxW0E16RUMRSych/V7Hu2B7MkTLvRXbrL4THeEaXfqDIrBlwoCDifkBbsh xtlHJpvMQa2e4TOhH9Ziu2M44ze6iXEhgqMVc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=URzNzA8vwTk8ltn99LExmH9Gj1Z1XVZ/xKYnVSUJ+eY=; b=X9r4Mac4MzsC0cmeVpSgBHTltZmi4zIjrzSOzF5xgZYEtmaC7kSycfWn5SVZ5NS6km v4umPAObGGpN28KR2bqS7TnruQ0SAGDFZtHmhpOYLISJ0F2S9Kkqf++Xta5kNlgPSj/P fub4K0pfg/yk8LZLmYrE8BHNayEIIAlPcH/qLFg6OU5sfYiKNYuGeuzbq/w8bdjCGLjn Ijs48FpuOQZfxXV4ChzXzX+y8jNvZ7iJiE/e9nknFbi5GVeLJyCXDIKLe0Gh3L3RLAPl AjeFrVEowoTYFQT+ksay5Iup4g09/3kXGULEZF/09WNzbH/YVVuJsnkR0ABKxhl8No1p 0ZBQ== X-Gm-Message-State: AOAM530oOvy9U4euw6QyQJdt6FI9sv8QmIayuoFXx/QMMULWaROStQnz hLNTDEoI39XKaAxzQ22UkYhUzUSRxDedRw== X-Google-Smtp-Source: ABdhPJyp/b+5at/LzYZqPekDe6AZ5C8y/A3NmSXVzEe0D96R5hR+Z4HeaCWpaT0rQwiE1EIoqRNcRQ== X-Received: by 2002:a05:6e02:4c4:: with SMTP id f4mr42333117ils.272.1621022242170; Fri, 14 May 2021 12:57:22 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id s23sm2749891iol.49.2021.05.14.12.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 12:57:21 -0700 (PDT) Subject: Re: [PATCH v2 07/10] thunderbolt: test: Remove sone casts which are no longer required To: David Gow , Mika Westerberg , Brendan Higgins Cc: Daniel Latypov , Shuah Khan , KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , linux-usb@vger.kernel.org, Shuah Khan References: <20210513193204.816681-1-davidgow@google.com> <20210513193204.816681-7-davidgow@google.com> <20210514060618.GA3511397@lahna.fi.intel.com> From: Shuah Khan Message-ID: Date: Fri, 14 May 2021 13:57:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 5/14/21 1:27 AM, David Gow wrote: > On Fri, May 14, 2021 at 2:08 PM Mika Westerberg > wrote: >> >> Hi, >> >> On Thu, May 13, 2021 at 12:32:01PM -0700, David Gow wrote: >>> With some of the stricter type checking in KUnit's EXPECT macros >>> removed, several casts in the thunderbolt KUnit tests are no longer >>> required. >>> >>> Remove the unnecessary casts, making the conditions clearer. >>> >>> Signed-off-by: David Gow >> >> Looks good. >> >> Does this go through KUnit tree or you want me to take it? In case of >> the former feel free to add: >> >> Acked-by: Mika Westerberg >> > > Thanks. I think it's probably easier for this to go in via the KUnit > tree, unless Brendan or Shuah have any objections. > It is fine either way unless there are dependencies on the KUnit tree. I can take this in through KUnit once Brendan looks at it. thanks, -- Shuah