linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: chia-yu.chang@nokia-bell-labs.com, horms@kernel.org,
	donald.hunter@gmail.com, xandfury@gmail.com,
	netdev@vger.kernel.org, dave.taht@gmail.com, pabeni@redhat.com,
	jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org,
	xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
	edumazet@google.com, andrew+netdev@lunn.ch, ast@fiberby.net,
	liuhangbin@gmail.com, shuah@kernel.org,
	linux-kselftest@vger.kernel.org, ij@kernel.org,
	ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
	g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
	mirja.kuehlewind@ericsson.com, cheshire@apple.com,
	rs.ietf@gmx.at, Jason_Livingood@comcast.com,
	vidhi_goel@apple.com
Subject: Re: [PATCH v18 net-next 1/5] sched: Struct definition and parsing of dualpi2 qdisc
Date: Fri, 13 Jun 2025 21:57:46 +0530	[thread overview]
Message-ID: <f9cf4cca-8e21-4de4-a5ab-c696f40ef385@oracle.com> (raw)
In-Reply-To: <20250613153725.7983-2-chia-yu.chang@nokia-bell-labs.com>

> +static void dualpi2_walk(struct Qdisc *sch, struct qdisc_walker *arg)
> +{
> +	unsigned int i;
> +
> +	if (arg->stop)
> +		return;
> +
> +	/* We statically define only 2 queues */
> +	for (i = 0; i < 2; i++) {
> +		if (arg->count < arg->skip) {
> +			arg->count++;
> +			continue;
> +		}
> +		if (arg->fn(sch, i + 1, arg) < 0) {
> +			arg->stop = 1;
> +			break;
> +		}
> +		arg->count++;
> +	}
> +}
> +
> +/* Minimal class support to handler tc filters */

handler -> handle

> +static const struct Qdisc_class_ops dualpi2_class_ops = {
> +	.leaf		= dualpi2_leaf,
> +	.find		= dualpi2_find,
> +	.tcf_block	= dualpi2_tcf_block,
> +	.bind_tcf	= dualpi2_bind,
> +	.unbind_tcf	= dualpi2_unbind,
> +	.walk		= dualpi2_walk,
> +};


Thanks,
Alok

  reply	other threads:[~2025-06-13 16:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-13 15:37 [PATCH v18 net-next 0/5] DUALPI2 patch chia-yu.chang
2025-06-13 15:37 ` [PATCH v18 net-next 1/5] sched: Struct definition and parsing of dualpi2 qdisc chia-yu.chang
2025-06-13 16:27   ` ALOK TIWARI [this message]
2025-06-13 15:37 ` [PATCH v18 net-next 2/5] sched: Dump configuration and statistics " chia-yu.chang
2025-06-13 15:37 ` [PATCH v18 net-next 3/5] sched: Add enqueue/dequeue " chia-yu.chang
2025-06-13 15:37 ` [PATCH v18 net-next 4/5] selftests/tc-testing: Add selftests for qdisc DualPI2 chia-yu.chang
2025-06-13 16:45   ` ALOK TIWARI
2025-06-13 15:37 ` [PATCH v18 net-next 5/5] Documentation: netlink: specs: tc: Add DualPI2 specification chia-yu.chang
2025-06-14  0:13   ` Jakub Kicinski
2025-06-14 16:17     ` Chia-Yu Chang (Nokia)
  -- strict thread matches above, loose matches on Subject: below --
2025-06-14 15:42 [PATCH v18 net-next 0/5] DUALPI2 patch chia-yu.chang
2025-06-14 15:42 ` [PATCH v18 net-next 1/5] sched: Struct definition and parsing of dualpi2 qdisc chia-yu.chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9cf4cca-8e21-4de4-a5ab-c696f40ef385@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=Jason_Livingood@comcast.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@fiberby.net \
    --cc=cheshire@apple.com \
    --cc=chia-yu.chang@nokia-bell-labs.com \
    --cc=dave.taht@gmail.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=g.white@cablelabs.com \
    --cc=horms@kernel.org \
    --cc=ij@kernel.org \
    --cc=ingemar.s.johansson@ericsson.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=koen.de_schepper@nokia-bell-labs.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=mirja.kuehlewind@ericsson.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rs.ietf@gmx.at \
    --cc=shuah@kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vidhi_goel@apple.com \
    --cc=xandfury@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).