From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2E64400 for ; Wed, 4 Dec 2024 01:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733274070; cv=none; b=iDFtdo+lXqktTKDs0fVhi/gT1gpIJaT+ameHU09WuXnEOlLiw7wNf0jxYgE239zKmp9eBHMIOnbV9b27yZVRyuL+9rC8cWGmMynG5vFBmxvb4x8NzS7iGUBkc8brVaVQzrfZ0EnwVrcF5JeeotaHvCjXfRdGEnx6d4mRRbgT9bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733274070; c=relaxed/simple; bh=+PnW8Rx8QB0eXrlBZgoHpq6Fxpv9sFiJp0O5DS2PCTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n3gIF6wwPnEc0cG87bjeHFj2ZrBGwIxDeLjuQasi58TOQIOITVUmFpPnkBmf+rp1T+cH9PHw9JPQfkLQN3FTHX9r7FuBJ3e7oXxRr92uzKYvvphm67VlAyVHBvzQwZBMvV/3U8dE+APmLNMe05yrSasrqnjdPorHO4eDHdp+F/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=O21RvWsB; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="O21RvWsB" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-8418a2f596fso201158739f.1 for ; Tue, 03 Dec 2024 17:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1733274068; x=1733878868; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NA+ElRETJKY5CqdJTdKRnj5fYbwfNKrJQ8Yc5F8bfeI=; b=O21RvWsBnhtQ/WVgO05CT5EXVUCJcnWaxDuH6WVNl3DuOEKN+579/pYgVGyzXLP50L 0s2pMeoDAuJjzWa92LlUslWOUPz6dng5QjgDF0CPgKUutLekMwR3woO3VydXbYZzO+r0 OS6/tvfn0D4ilchWmRBKaYDpxrPgfIILMNlA4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733274068; x=1733878868; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NA+ElRETJKY5CqdJTdKRnj5fYbwfNKrJQ8Yc5F8bfeI=; b=KzlnCD5zOPnkf6zqOG5vRx3x6tff8uprMRDH/b63XB//OUon6ATlWpNhwpqYSSQ2jk VJW36be9oxV5i6hUoJZDsHBNSj2tqw0ihMudWuXrcFi+6GsqRiCKLIo4H/mtmjBMN0zA HLqHkqfTyo6a3wxRMw1PfI7CFUFGpHBU5seAm0F5o7d6Q/CQ4AFmDoAtk+oKDEIHSIzp sW7ATdX/E7dVI4AEfBriv4VWKkM4Sl9FmduxuHygSB9Pqesgvd59SDtmFSuTzZ5eOSJN pEt0m4ZppPs919iEKb4iaXcQUCSmRZ+RntNwMFFYpHgfRCIQpUEr6Gzqq7wC0jNpmwsS yTJw== X-Forwarded-Encrypted: i=1; AJvYcCXBuKiWTsg2ePWo9uh35Jvl3X0Sa3evj3zNN0lBMEvVRxQotD5PJ+6zbK7qD4P2vbSqo/zYvqLSs34bW2+DeMY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/nna1G2x3hwkfUKmH9KJ6pGWMrFZw+ZyBfMiLUx7Jn1MprL9u xOL7CIGxn1lPvpvzCWFSLqrlf/VoZmOvcApA3i46irDWC8wUwDgPVjaY7dbD9CU= X-Gm-Gg: ASbGncsy+Lrx3d5CnB2KbjqMCa7iHqE0DxorSqPN4F7YlvQOpvliSFkgn2bEKMgxJQj sYvUhX+cRim7IFDFXfuhmwy2xCqvtqTqd1yP5ygaoPXAX5brgsWD2wRzDoG0uMw9/qs4VlNy0Di u7uwudSMMRPtP+ERpuLJG5W3oTpM5x7/ACzw2EeXhpkg0q+aLcP+iY37VC0inPmS27Gyqio/xBH nCqMCtfgbFIOL0+raAOOQee5RaJbSJqayOVWxNM72rHC59vYOQrGBZnJYqZ6w== X-Google-Smtp-Source: AGHT+IFa+Bd2NpYOHu6EHzfrniiaLxPU/ePwfT0m1+/YTPvjeHG3Isi7m4kg/5QlpdI+LxP5aHV9sA== X-Received: by 2002:a05:6e02:164f:b0:3a6:ac4e:264a with SMTP id e9e14a558f8ab-3a7f9a46431mr58360885ab.10.1733274067594; Tue, 03 Dec 2024 17:01:07 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e230e779e8sm2783394173.137.2024.12.03.17.01.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 17:01:06 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 18:01:06 -0700 Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/ftrace: adjust offset for kprobe syntax error test To: Steven Rostedt , Hari Bathini Cc: Shuah Khan , linux-kselftest@vger.kernel.org, Masami Hiramatsu , Michael Ellerman , Madhavan Srinivasan , "Naveen N. Rao" , linuxppc-dev , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20241129202621.721159-1-hbathini@linux.ibm.com> <20241202144111.75d1bb3b@gandalf.local.home> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241202144111.75d1bb3b@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/24 12:41, Steven Rostedt wrote: > On Sat, 30 Nov 2024 01:56:21 +0530 > Hari Bathini wrote: > >> In 'NOFENTRY_ARGS' test case for syntax check, any offset X of >> `vfs_read+X` except function entry offset (0) fits the criterion, >> even if that offset is not at instruction boundary, as the parser >> comes before probing. But with "ENDBR64" instruction on x86, offset >> 4 is treated as function entry. So, X can't be 4 as well. Thus, 8 >> was used as offset for the test case. On 64-bit powerpc though, any >> offset <= 16 can be considered function entry depending on build >> configuration (see arch_kprobe_on_func_entry() for implementation >> details). So, use `vfs_read+20` to accommodate that scenario too. >> >> Suggested-by: Masami Hiramatsu >> Signed-off-by: Hari Bathini > > Acked-by: Steven Rostedt (Google) > > Shuah, > > Can you take this through your tree? Yes I can take it. I do have question about whether this is a fix - sounds like it is from the change log. Clearly stating that it is a fix will help so it can be picked up for stables. thanks, -- Shuah