From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B12C19F28 for ; Wed, 3 Aug 2022 04:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233872AbiHCEoK (ORCPT ); Wed, 3 Aug 2022 00:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiHCEoJ (ORCPT ); Wed, 3 Aug 2022 00:44:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCDB231377; Tue, 2 Aug 2022 21:44:07 -0700 (PDT) Received: from [192.168.43.224] (92.40.178.41.threembb.co.uk [92.40.178.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gtucker) by madras.collabora.co.uk (Postfix) with ESMTPSA id 544F76601B45; Wed, 3 Aug 2022 05:44:05 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1659501845; bh=7yGjpM0HgyH1Sv1LbDc+Kr8ogiOCMctPl1YxkMRebl0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TPf1Y9FH1Nbix3eA+tAq+62JUvC/jvDXV+65YgYFVJZp+vEJVhAEsmGbU2BLxOtut mW2sJjAot/PTOW3P2mZI8bZ9gFN/JuP5mLuAusw2RAPty7pNHtU/k8siKIZQYOlNb/ 0XgL5c5VADYtEYNYIfo24/NmnZmyFzYPXuCe+TOAuR+Kf5iZ5rRURghlfth9r4iDF3 MbTWTGNhj27cmg83jfkdTTR/mm/mAoz4gWichyBFDIM9p6wXjkEE8CuX4i5CiFmH3p JWwQn4XySe3inmwSaMjsk3YvcNBtlCAjbsTSVolzCUD6qjNewl16Rxu1lMxNTibA52 j5ShCAFIAH47g== Message-ID: Date: Wed, 3 Aug 2022 06:44:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [GIT PULL] Kselftest update for Linux 5.20-rc1 Content-Language: en-US To: Shuah Khan , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Linus Torvalds Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , linux-security-module References: <430ef132-2ac7-e1be-68ed-3d9c27382143@linuxfoundation.org> <2838c247-0648-3828-efb3-e11d7a0616b2@digikod.net> <84560b65-12ed-da24-3698-45484f80802a@linuxfoundation.org> From: Guillaume Tucker In-Reply-To: <84560b65-12ed-da24-3698-45484f80802a@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On 02/08/2022 15:29, Shuah Khan wrote: > On 8/2/22 3:51 AM, Mickaël Salaün wrote: >> Hi, >> >> This change breaks the Landlock test build when performed on the tools/testing/selftests/landlock directory because the (non-system/up-to-date) kernel headers aren't found. Looking at the use of top_srcdir and HDR_PATH, it seems that multiple subsystems are using this feature. I consider this change a regression. >> > > I did a build test from the top level before sending the pull request > and didn't catch this breakage as a result. This breaks when build is > run from the test directory. > > We have had several problems related to khdr_dir and target and decided > to move away from it with this change. > >> It also removes the check on up-to-date kernel headers (thanks to the Makefile's target timestamp). >> >> I wasn't CCed for this change impacting Landlock [1]. Please keep in mind to add at least maintainers and related mailing-lists for changes on related subsystems. >> > > That is the usual practice and if I notice missing maintainers, I add > them. We missed this one. > >> The following patch almost revert commit a917dd94b832 ("selftests/landlock: drop deprecated headers dependency") and partially fixes commit 49de12ba06ef ("selftests: drop KSFT_KHDR_INSTALL make target"): >> > > Guillaume, > > Will you be able to look at this and send a patch on top? I will > send another pull request before merge window closes? Sure, I'll take a look today. Also I'll see if we can add some extra build tests in KernelCI for the kselftest tree to catch issues like these automatically. Best wishes, Guillaume >> --- a/tools/testing/selftests/landlock/Makefile >> +++ b/tools/testing/selftests/landlock/Makefile >> @@ -9,10 +9,13 @@ TEST_GEN_PROGS := $(src_test:.c=) >>   TEST_GEN_PROGS_EXTENDED := true >> >>   OVERRIDE_TARGETS := 1 >> +top_srcdir = ../../../.. >>   include ../lib.mk >> >> +khdr_dir = $(top_srcdir)/usr/include >> + >>   $(OUTPUT)/true: true.c >>       $(LINK.c) $< $(LDLIBS) -o $@ -static >> >> -$(OUTPUT)/%_test: %_test.c ../kselftest_harness.h common.h >> -    $(LINK.c) $< $(LDLIBS) -o $@ -lcap >> +$(OUTPUT)/%_test: %_test.c $(khdr_dir)/linux/landlock.h ../kselftest_harness.h common.h >> +    $(LINK.c) $< $(LDLIBS) -o $@ -lcap -I$(khdr_dir) >> >> >> This doesn't fix the header timestamp check though. >> > > thanks, > -- Shuah