From: Paolo Abeni <pabeni@redhat.com>
To: Stanislav Fomichev <stfomichev@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
edumazet@google.com, sdf@fomichev.me, matttbe@kernel.org,
linux-kselftest@vger.kernel.org,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode
Date: Thu, 26 Sep 2024 11:03:38 +0200 [thread overview]
Message-ID: <fd29c5e5-219d-44ad-8403-1abe4015f75c@redhat.com> (raw)
In-Reply-To: <ZuyR0JuU_H3MvEmX@mini-arch>
On 9/19/24 23:04, Stanislav Fomichev wrote:
> On 09/19, Willem de Bruijn wrote:
>> From: Willem de Bruijn <willemb@google.com>
>>
>> Some packetdrill tests are flaky in debug mode. As discussed, increase
>> tolerance.
>>
>> We have been doing this for debug builds outside ksft too.
>>
>> Previous setting was 10000. A manual 50 runs in virtme-ng showed two
>> failures that needed 12000. To be on the safe side, Increase to 14000.
>>
>> Link: https://lore.kernel.org/netdev/Zuhhe4-MQHd3EkfN@mini-arch/
>> Fixes: 1e42f73fd3c2 ("selftests/net: packetdrill: import tcp/zerocopy")
>> Reported-by: Stanislav Fomichev <sdf@fomichev.me>
>> Signed-off-by: Willem de Bruijn <willemb@google.com>
>
> Acked-by: Stanislav Fomichev <sdf@fomichev.me>
>
> Thanks! Should probably go to net-next though? (Not sure what's
> the bar for selftests fixes for 'net')
FTR, we want this kind of fixes in net, to reach self-test stability in
both trees ASAP.
Cheers,
Paolo
next prev parent reply other threads:[~2024-09-26 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 12:43 [PATCH net] selftests/net: packetdrill: increase timing tolerance in debug mode Willem de Bruijn
2024-09-19 13:55 ` Simon Horman
2024-09-19 21:04 ` Stanislav Fomichev
2024-09-26 9:03 ` Paolo Abeni [this message]
2024-09-19 22:03 ` Matthieu Baerts
2024-09-26 9:12 ` Matthieu Baerts
2024-09-26 9:28 ` Willem de Bruijn
2024-09-26 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd29c5e5-219d-44ad-8403-1abe4015f75c@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=stfomichev@gmail.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox