From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: Filipe Xavier <felipeaggger@gmail.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Shuah Khan <shuah@kernel.org>
Cc: live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, felipe_life@live.com
Subject: Re: [PATCH 0/2] selftests: livepatch: test if ftrace can trace a livepatched function
Date: Tue, 11 Mar 2025 22:53:10 -0300 [thread overview]
Message-ID: <fe554a6efe55d7a9fda58c3aebb56322f742b12d.camel@suse.com> (raw)
In-Reply-To: <20250306-ftrace-sftest-livepatch-v1-0-a6f1dfc30e17@gmail.com>
On Thu, 2025-03-06 at 18:51 -0300, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
>
> Signed-off-by: Filipe Xavier <felipeaggger@gmail.com>
> ---
> Filipe Xavier (2):
> selftests: livepatch: add new ftrace helpers functions
> selftests: livepatch: test if ftrace can trace a livepatched
> function
>
> tools/testing/selftests/livepatch/functions.sh | 45
> ++++++++++++++++++++++++
> tools/testing/selftests/livepatch/test-ftrace.sh | 35
> ++++++++++++++++++
> 2 files changed, 80 insertions(+)
>
Thanks for sending this new version! One interesting thing is that you
created a new patchset, instead of iterating on the same one, and this
triggered a bug on b4[1]!
You also missed the changelog since v2, but AFAICS you addressed all
comments from me, Joe and Petr, per [2].
For the two patches:
Reviewed-by: Marcos Paulo de Souza <mpdesouza@suse.com>
[1]: https://github.com/mricon/b4/issues/58
[2]:
https://lore.kernel.org/live-patching/b2637bad-9022-496a-9b83-0d348a6350b4@gmail.com/T/#m14bc5c118490c1b17e782a0f0173c1fb70d187c7
> ---
> base-commit: 848e076317446f9c663771ddec142d7c2eb4cb43
> change-id: 20250306-ftrace-sftest-livepatch-60d9dc472235
>
> Best regards,
prev parent reply other threads:[~2025-03-12 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 21:51 [PATCH 0/2] selftests: livepatch: test if ftrace can trace a livepatched function Filipe Xavier
2025-03-06 21:51 ` [PATCH PATCH 1/2] selftests: livepatch: add new ftrace helpers functions Filipe Xavier
2025-03-06 21:51 ` [PATCH PATCH 2/2] selftests: livepatch: test if ftrace can trace a livepatched function Filipe Xavier
2025-03-14 13:14 ` Miroslav Benes
2025-03-14 19:00 ` Filipe Xavier
2025-03-17 9:07 ` Miroslav Benes
2025-03-18 12:31 ` Filipe Xavier
2025-03-12 1:53 ` Marcos Paulo de Souza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe554a6efe55d7a9fda58c3aebb56322f742b12d.camel@suse.com \
--to=mpdesouza@suse.com \
--cc=felipe_life@live.com \
--cc=felipeaggger@gmail.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).