From: Wainer dos Santos Moschetta <wainersm@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
david@redhat.com
Subject: Re: [PATCH 2/2] selftests: kvm: Add mem_slot_test test
Date: Thu, 2 Apr 2020 10:48:51 -0300 [thread overview]
Message-ID: <fef1fa29-b189-aa97-eea4-0340a72a6f67@redhat.com> (raw)
In-Reply-To: <20200401063817.gb5f4ah45qvtqkhw@kamzik.brq.redhat.com>
On 4/1/20 3:38 AM, Andrew Jones wrote:
> On Tue, Mar 31, 2020 at 06:42:21PM -0300, Wainer dos Santos Moschetta wrote:
>> It would be nice to exercise the code by adding slots with different page
>> flags. But for this test that simple checks the limit, the use of
>> KVM_MEM_READONLY is enough. I will change it on v2.
> It would be good to test more memslot error conditions as well. Do you plan
> to expand on this test?
Yes, I do. For example, check memory slots addresses can't overlap.
>
> Thanks,
> drew
next prev parent reply other threads:[~2020-04-02 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 20:43 [PATCH 0/2] selftests: kvm: Introduce the mem_slot_test test Wainer dos Santos Moschetta
2020-03-30 20:43 ` [PATCH 1/2] selftests: kvm: Add vm_get_fd() in kvm_util Wainer dos Santos Moschetta
2020-03-31 7:52 ` Andrew Jones
2020-03-30 20:43 ` [PATCH 2/2] selftests: kvm: Add mem_slot_test test Wainer dos Santos Moschetta
2020-03-31 8:16 ` Andrew Jones
2020-03-31 21:42 ` Wainer dos Santos Moschetta
2020-04-01 6:38 ` Andrew Jones
2020-04-02 13:48 ` Wainer dos Santos Moschetta [this message]
2020-04-02 9:00 ` Andrew Jones
2020-04-02 13:56 ` Wainer dos Santos Moschetta
2020-04-02 14:44 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fef1fa29-b189-aa97-eea4-0340a72a6f67@redhat.com \
--to=wainersm@redhat.com \
--cc=david@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox