Linux Kernel Selftest development
 help / color / mirror / Atom feed
From: Vlad Buslov <vladbu@mellanox.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Vlad Buslov <vladbu@mellanox.com>,
	"open list\:KERNEL SELFTEST FRAMEWORK" 
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
	David Miller <davem@davemloft.net>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH net-next] selftests: fix flower parent qdisc
Date: Thu, 14 May 2020 09:30:18 +0300	[thread overview]
Message-ID: <vbfy2pvxc3p.fsf@mellanox.com> (raw)
In-Reply-To: <CAM_iQpX2nBc3ppmvxJPoECCfZY1v1bhiYC_7fjAbXKCqdA3nLg@mail.gmail.com>


On Wed 13 May 2020 at 21:35, Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Wed, May 13, 2020 at 10:58 AM Vlad Buslov <vladbu@mellanox.com> wrote:
>>
>> Flower tests used to create ingress filter with specified parent qdisc
>> "parent ffff:" but dump them on "ingress". With recent commit that fixed
>> tcm_parent handling in dump those are not considered same parent anymore,
>> which causes iproute2 tc to emit additional "parent ffff:" in first line of
>> filter dump output. The change in output causes filter match in tests to
>> fail.
>
> My commit simply restores the old behavior prior to 4.15, so are you
> saying these tests never work correctly on kernels <= 4.15? If so,
> they must be fixed no matter of my commit, right?
>
> Thanks.

I think all of these tests are newer than 4.15.

  reply	other threads:[~2020-05-14  6:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 17:57 [PATCH net-next] selftests: fix flower parent qdisc Vlad Buslov
2020-05-13 18:35 ` Cong Wang
2020-05-14  6:30   ` Vlad Buslov [this message]
2020-05-13 19:57 ` David Miller
2020-05-14  6:30   ` Vlad Buslov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vbfy2pvxc3p.fsf@mellanox.com \
    --to=vladbu@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=shuah@kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox