From mboxrd@z Thu Jan  1 00:00:00 1970
From: Linas Vepstas <linas@austin.ibm.com>
Subject: PCI Power management (was: Re: [PATCH 4/13]: PCI Err: e100 ethernet
	driver recovery
Date: Thu, 30 Jun 2005 15:39:31 -0500
Message-ID: <20050630203931.GY28499@austin.ibm.com>
References: <20050628235848.GA6376@austin.ibm.com>
	<1120009619.5133.228.camel@gaston>
	<20050629155954.GH28499@austin.ibm.com>
	<20050629165828.GA73550@muc.de>
Mime-Version: 1.0
Return-path: <linuxppc64-dev-bounces@ozlabs.org>
Content-Disposition: inline
In-Reply-To: <20050629165828.GA73550@muc.de>
List-Id: <linux-laptop.vger.kernel.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc64-dev>,
	<mailto:linuxppc64-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc64-dev>
List-Post: <mailto:linuxppc64-dev@ozlabs.org>
List-Help: <mailto:linuxppc64-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc64-dev>,
	<mailto:linuxppc64-dev-request@ozlabs.org?subject=subscribe>
Sender: linuxppc64-dev-bounces@ozlabs.org
Errors-To: linuxppc64-dev-bounces@ozlabs.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Andi Kleen <ak@muc.de>, sfr@canb.auug.org.au
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>, long <tlnguyen@snoqualmie.dp.intel.com>, linux-laptop@vger.kernel.org, linux-kernel@vger.kernel.org, pavel@suse.cz, Paul Mackerras <paulus@samba.org>, Greg KH <greg@kroah.com>, linuxppc64-dev <linuxppc64-dev@ozlabs.org>, linux-pci@atrey.karlin.mff.cuni.cz, johnrose@us.ibm.com, mochel@transmeta.com

On Wed, Jun 29, 2005 at 06:58:29PM +0200, Andi Kleen was heard to remark:
> > Yep, OK. Pushig the timer would in fact break if the device was marked
> > perm disabled.
> 
> I think for network drivers you should just write a generic error handler
> (perhaps in net/core/dev.c) that calls the watchdog handler. 
> Then all drivers could be easily converted without much code duplication.

Well, there's no watchdog per-se in "struct net_device" -- are you
suggesting I add one?

It looks like I can almost create generic handlers for net devices; 
looks like calling netdev->stop() is enough to handle the error
detection. 

However, a generic bringup would need to call pci_enable_device(), 
and net/core/dev.c does not include pci.h so I can't really do it 
there.  Other than that, a generic recovry routine looks like it might
be possible; I'll have to experiment; its hard to tell by reading code.

This might be the wrong paradigm, though.  The pci error recovery 
routines are *almost identical* to the power-management suspend/resume
routines.  From what I can tell, the only real difference is that 
I want to not actually turn off/on the power. 

Thus, the right thing to do might be to split up the 
struct pci_dev->suspend() and pci_dev->resume() calls into

   suspend()
   poweroff()
   poweron()
   resume()

and then have the generic pci error recovery routines call
suspend/resume only, skipping the poweroff-on calls.  Does that 
sound good?

I'm not sure I can pull this off without having someone from 
the power-management world throw a brick at me.

--linas