From: Jingoo Han <jg1.han@samsung.com>
To: 'Bryan Wu' <cooloney@gmail.com>
Cc: linux-leds@vger.kernel.org, 'Richard Purdie' <rpurdie@rpsys.net>,
'Jingoo Han' <jg1.han@samsung.com>,
'Dave Hansen' <dave@linux.vnet.ibm.com>,
'Javier Martinez Canillas' <javier.martinez@collabora.co.uk>
Subject: [PATCH 1/2] leds: leds-ss4200: remove unnecessary __initdata marker
Date: Fri, 28 Feb 2014 16:25:07 +0900 [thread overview]
Message-ID: <000c01cf3456$34b8ecc0$9e2ac640$%han@samsung.com> (raw)
Remove unnecessary __initdata marker, because it is not right
for a module parameter. It may make the kernel oops problem.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/leds/leds-ss4200.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/leds-ss4200.c b/drivers/leds/leds-ss4200.c
index 2bdf642..2eb3ef6 100644
--- a/drivers/leds/leds-ss4200.c
+++ b/drivers/leds/leds-ss4200.c
@@ -78,7 +78,7 @@ static int __init ss4200_led_dmi_callback(const struct dmi_system_id *id)
return 1;
}
-static bool __initdata nodetect;
+static bool nodetect;
module_param_named(nodetect, nodetect, bool, 0);
MODULE_PARM_DESC(nodetect, "Skip DMI-based hardware detection");
--
1.7.10.4
next reply other threads:[~2014-02-28 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 7:25 Jingoo Han [this message]
2014-02-28 7:26 ` [PATCH 2/2] leds: clevo-mail: remove unnecessary __initdata marker Jingoo Han
2014-02-28 10:29 ` Uwe Kleine-König
2014-02-28 20:24 ` Bryan Wu
2014-02-28 22:33 ` [PATCH 1/2] leds: leds-ss4200: " Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000c01cf3456$34b8ecc0$9e2ac640$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=cooloney@gmail.com \
--cc=dave@linux.vnet.ibm.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).