linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: 'Bryan Wu' <cooloney@gmail.com>
Cc: linux-leds@vger.kernel.org,
	"'Richard Purdie'" <rpurdie@rpsys.net>,
	"'Jingoo Han'" <jg1.han@samsung.com>,
	"'Márton Németh'" <nm127@freemail.hu>,
	"'Uwe Kleine-König'" <u.kleine-koenig@pengutronix.de>,
	"'Ondrej Zary'" <linux@rainbow-software.org>
Subject: [PATCH 4/5] leds: clevo-mail: fix incorrect placement of __initdata marker
Date: Wed, 26 Feb 2014 14:14:49 +0900	[thread overview]
Message-ID: <000e01cf32b1$ac754340$055fc9c0$%han@samsung.com> (raw)
In-Reply-To: <000b01cf32b0$eb62fe40$c228fac0$%han@samsung.com>

The __initdata marker can be virtually anywhere on the line,
EXCEPT right after "struct". The preferred location is before
the "=" sign if there is one, or before the trailing ";"
otherwise. It also fixes the following chechpatch warning.

  WARNING: __initdata should be placed after nodetect

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/leds/leds-clevo-mail.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-clevo-mail.c b/drivers/leds/leds-clevo-mail.c
index d93e245..5974810 100644
--- a/drivers/leds/leds-clevo-mail.c
+++ b/drivers/leds/leds-clevo-mail.c
@@ -19,7 +19,7 @@ MODULE_AUTHOR("Márton Németh <nm127@freemail.hu>");
 MODULE_DESCRIPTION("Clevo mail LED driver");
 MODULE_LICENSE("GPL");
 
-static bool __initdata nodetect;
+static bool nodetect __initdata;
 module_param_named(nodetect, nodetect, bool, 0);
 MODULE_PARM_DESC(nodetect, "Skip DMI hardware detection");
 
-- 
1.7.10.4

  parent reply	other threads:[~2014-02-26  5:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26  5:09 [PATCH 1/5] leds: leds-ss4200: fix incorrect placement of __initdata marker Jingoo Han
2014-02-26  5:10 ` [PATCH 2/5] leds: leds-ss4200: remove DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2014-02-27 18:01   ` Bryan Wu
2014-02-26  5:11 ` [PATCH 3/5] leds: lp5562: remove unnecessary parentheses Jingoo Han
2014-02-27 18:03   ` Bryan Wu
2014-02-26  5:14 ` Jingoo Han [this message]
2014-02-26  8:30   ` [PATCH 4/5] leds: clevo-mail: fix incorrect placement of __initdata marker Uwe Kleine-König
2014-02-27 18:16     ` Bryan Wu
2014-02-26  5:16 ` [PATCH 5/5] leds: blinkm: remove unnecessary spaces Jingoo Han
2014-02-26  6:25   ` Jan-Simon Möller
2014-02-27 18:22     ` Bryan Wu
2014-02-27 18:00 ` [PATCH 1/5] leds: leds-ss4200: fix incorrect placement of __initdata marker Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000e01cf32b1$ac754340$055fc9c0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=cooloney@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    --cc=nm127@freemail.hu \
    --cc=rpurdie@rpsys.net \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).