From: Hans de Goede <hdegoede@redhat.com>
To: Yauhen Kharuzhy <jekhor@gmail.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs
Date: Thu, 14 Feb 2019 11:04:44 +0100 [thread overview]
Message-ID: <079efdd4-2259-1e6f-48dd-5876f2bd7a93@redhat.com> (raw)
In-Reply-To: <1df39a63-533f-bb68-a056-a0241f148be9@redhat.com>
Hi,
On 13-02-19 23:43, Hans de Goede wrote:
> Hi,
>
> On 12-02-19 21:59, Yauhen Kharuzhy wrote:
>> Add support for LEDs connected to the Intel Cherry Trail Whiskey Cove
>> PMIC. Charger and general-purpose leds are supported. Hardware blinking
>> is implemented, breathing is not.
>>
>> This driver was tested with Lenovo Yoga Book notebook.
<snip>
> Note that in my experience the "charging" mode only works
> when bits 0-1 have the value 10.
Ok, scrap that I don't know where this info in my notes
came from (probably user error), the power-on-reset
value for bits 0-1 is 00 and then the hw controls the
charging LED just fine. So your code is right, bit 0
switches between hw-control (0) and user-control (1) and
bit 1 is on/off when user-control is enabled.
Regards,
Hans
next prev parent reply other threads:[~2019-02-14 10:04 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 20:58 [PATCH v2 0/2] Intel Cherry Trail Whiskey Cove LEDs support Yauhen Kharuzhy
2019-02-12 20:59 ` [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs Yauhen Kharuzhy
2019-02-13 22:43 ` Hans de Goede
2019-02-13 23:07 ` Pavel Machek
2019-02-13 23:25 ` Hans de Goede
2019-02-13 23:38 ` Pavel Machek
2019-02-14 9:57 ` Hans de Goede
2019-02-14 11:14 ` Pavel Machek
2019-02-14 11:31 ` Hans de Goede
2019-02-14 12:28 ` Pavel Machek
2019-02-15 21:41 ` Jacek Anaszewski
2019-02-15 23:26 ` Pavel Machek
2019-02-14 21:46 ` Jacek Anaszewski
2019-02-14 23:03 ` Pavel Machek
2019-02-15 7:27 ` Yauhen Kharuzhy
2019-02-15 21:43 ` Jacek Anaszewski
2019-02-16 11:26 ` Yauhen Kharuzhy
2019-02-15 11:27 ` Hans de Goede
2019-02-15 13:02 ` Pavel Machek
2019-02-15 21:42 ` Jacek Anaszewski
2019-02-15 22:26 ` Hans de Goede
2019-02-15 22:31 ` Jacek Anaszewski
2019-02-15 23:14 ` Hans de Goede
2019-02-16 17:02 ` Jacek Anaszewski
2019-02-16 19:01 ` Hans de Goede
2019-02-16 19:37 ` Pavel Machek
2019-02-16 20:55 ` Hans de Goede
2019-02-17 0:08 ` Pavel Machek
2019-02-17 14:10 ` Hans de Goede
2019-02-17 17:45 ` Pavel Machek
2019-02-18 11:12 ` Hans de Goede
2019-02-18 21:59 ` Jacek Anaszewski
2019-02-16 21:54 ` Jacek Anaszewski
2019-02-16 22:03 ` Hans de Goede
2019-02-17 12:40 ` Jacek Anaszewski
2019-02-14 11:28 ` Pavel Machek
2019-02-14 21:34 ` Yauhen Kharuzhy
2019-02-14 6:55 ` Yauhen Kharuzhy
2019-02-14 10:04 ` Hans de Goede [this message]
2019-02-12 20:59 ` [PATCH v2 2/2] mfd: Add leds MFD cell for intel_soc_pmic_chtwc Yauhen Kharuzhy
2019-02-13 21:24 ` Jacek Anaszewski
2019-03-20 9:56 ` Lee Jones
2019-03-20 9:57 ` Lee Jones
2019-04-21 19:28 ` [PATCH v2 0/2] Intel Cherry Trail Whiskey Cove LEDs support Hans de Goede
2019-04-24 18:32 ` Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=079efdd4-2259-1e6f-48dd-5876f2bd7a93@redhat.com \
--to=hdegoede@redhat.com \
--cc=jekhor@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).