From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Murphy Subject: Re: [PATCH 2/2] leds: tlc591xx: Use the OF version of the LED registration function Date: Mon, 1 Jul 2019 10:36:34 -0500 Message-ID: <102194fe-e4d1-fa36-16f7-2a933e646bb5@ti.com> References: <20190701152602.31716-1-jjhiblot@ti.com> <20190701152602.31716-3-jjhiblot@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190701152602.31716-3-jjhiblot@ti.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Jean-Jacques Hiblot , jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, tomi.valkeinen@ti.com List-Id: linux-leds@vger.kernel.org JJ On 7/1/19 10:26 AM, Jean-Jacques Hiblot wrote: > The driver parses the device-tree to identify which LED should be handled. > Since the information about the device node is known at this time, we can > provide the LED core with it. It may be useful later. > > Signed-off-by: Jean-Jacques Hiblot > --- > drivers/leds/leds-tlc591xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c > index 14e47ff44df5..6a2936c94b73 100644 > --- a/drivers/leds/leds-tlc591xx.c > +++ b/drivers/leds/leds-tlc591xx.c > @@ -207,7 +207,7 @@ tlc591xx_probe(struct i2c_client *client, > led->led_no = idx++; > led->ldev.brightness_set_blocking = tlc591xx_brightness_set; > led->ldev.max_brightness = LED_FULL; > - err = devm_led_classdev_register(dev, &led->ldev); > + err = devm_of_led_classdev_register(dev, child, &led->ldev); > if (err < 0) { > dev_err(dev, "couldn't register LED %s\n", > led->ldev.name); Reviewed-by: Dan Murphy