From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C86C71136 for ; Fri, 18 Aug 2023 09:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358831AbjHRI7l (ORCPT ); Fri, 18 Aug 2023 04:59:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358827AbjHRI7P (ORCPT ); Fri, 18 Aug 2023 04:59:15 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9992C358D for ; Fri, 18 Aug 2023 01:59:11 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4ff09632194so864785e87.2 for ; Fri, 18 Aug 2023 01:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692349150; x=1692953950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xJm4S8usi6aiGwBH5M9kQvrP7KTSyu9RrSuKCbpG3qc=; b=uhWStpwsgqhysvBfgJM2Y4/I23javHbK8RpVUJTsKU2LIHQGgHEztHaUQaHH+00WMU A0MxbS+x+GBeUeKrhhD5PzIiUAfQzsqvEppREpmYsL597po+xJPOfyjsIIJ8WDXrOkoM kxece0OZmjftOcz+gD0JD3TKqHCDpwptqQFsyEe4uuxmISCoCzqWLRo/oXQWCnMwoBVm nEALUpEMxEeAXEGPK7PAQOlXzKi96Ez66WWF9c3wG8pcaxDY0nRHXqAksN5CjO9J7+Xl saDyo9jfyZa81Nc3VNc1I9Lgqb58WnUvNxixtDZp/MhnOVqwyw8G/nhrnNcNPKdXqfC6 lyGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692349150; x=1692953950; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xJm4S8usi6aiGwBH5M9kQvrP7KTSyu9RrSuKCbpG3qc=; b=Czj/eMu9MkSTsAhRRahxEF/OjPFanDehHb9v3wN617hspsZBqPvKAC5cu7TG2lZjB3 jF3Aa0RbYLZk+r/jD+UlyyqGkHM2MMl/s5iCmslLbqUCNzF5DJqmugzLooVStPcQfokk /2zmRuyAe7r79YDszsJmDo+Yl5RHD+/aAgBc28uaWO3DbYBOxFHSczbHFnTiYniabLkT NbOe7iojCucNzT+HXkR64iM4r9BjqffNHQjaDqKSi2OeMy7Ey0v06tkYBFPUyjmgAvVK e7rwOICHQLJGK+tWXyUkwB+DJxVtK6BibZPbnpEaYbZ4EFhGURZYQ7zLnXODUmGvY9WA bzRQ== X-Gm-Message-State: AOJu0Yz+fWyars+eMh0Bv/Y3fhrVywqzjd8pfHS7Coef5cPpgTdrYlU2 ejNKmU/PCklYPBG4vkhxsATz2Q== X-Google-Smtp-Source: AGHT+IHhngfMVyaJ/vZRalrs4RKZIIe8Zsyq7PkcVRaJypLYHHr1czYftbfcIR3E9G5BsBjw3kIcqg== X-Received: by 2002:ac2:5b0c:0:b0:4f8:5885:61e with SMTP id v12-20020ac25b0c000000b004f85885061emr1196962lfn.40.1692349149818; Fri, 18 Aug 2023 01:59:09 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id x12-20020aa7cd8c000000b0052595b17fd4sm841685edv.26.2023.08.18.01.59.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Aug 2023 01:59:09 -0700 (PDT) Message-ID: <10495cea-b8bb-df1d-3971-6a635ba301fb@linaro.org> Date: Fri, 18 Aug 2023 10:59:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 1/7] dt-bindings: soc: qcom: Add qcom,pbs bindings Content-Language: en-US To: Rob Herring , Anjelique Melendez Cc: pavel@ucw.cz, lee@kernel.org, thierry.reding@gmail.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, luca.weiss@fairphone.com, konrad.dybcio@linaro.org, u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org References: <20230814235918.10396-1-quic_amelende@quicinc.com> <20230814235918.10396-2-quic_amelende@quicinc.com> <102328fa-5699-4731-d639-079bce8863a5@linaro.org> <20230817162624.GA1444880-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20230817162624.GA1444880-robh@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On 17/08/2023 18:26, Rob Herring wrote: > On Tue, Aug 15, 2023 at 10:36:39PM +0200, Krzysztof Kozlowski wrote: >> On 15/08/2023 01:59, Anjelique Melendez wrote: >>> Add binding for the Qualcomm Programmable Boot Sequencer device. >>> >>> Signed-off-by: Anjelique Melendez >>> --- >>> .../bindings/soc/qcom/qcom,pbs.yaml | 46 +++++++++++++++++++ >>> 1 file changed, 46 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> new file mode 100644 >>> index 000000000000..b502ca72266a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml >>> @@ -0,0 +1,46 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Technologies, Inc. Programmable Boot Sequencer >>> + >>> +maintainers: >>> + - Anjelique Melendez >>> + >>> +description: | >>> + The Qualcomm Technologies, Inc. Programmable Boot Sequencer (PBS) >>> + supports triggering power up and power down sequences for clients >>> + upon request. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - qcom,pmi632-pbs >>> + - const: qcom,pbs >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> +required: >>> + - compatible >>> + - reg >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + >>> + pmic@0 { >> >> This should be rather just "pmic", because the examples have >> address-cells=1 and size-cells=1, which is not correct in this context. > > But there's a 'reg' property so you can't drop the unit-address. The bus > node (spmi) needs to be added. reg also can be dropped. I am not sure whether parent PMIC bus is important here. Best regards, Krzysztof