Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board

Jacek Anaszewski
2019-08-27T21:18:11Z

Oleh,

On 8/27/19 11:11 PM, Oleh Kravchenko wrote:
> Yes it has this include :)
>
> $ git remote -v
> origin git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git (fetch)
> origin git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git (push)
>
> $ git fetch --all -p
> Fetching origin
>
> $ git log origin/master -1
> commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b (tag: v5.3-rc1, origin/master, origin/HEAD)
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sun Jul 21 14:05:38 2019 -0700

You need to checkout for-next branch.

> Linus 5.3-rc1
>
> $ grep -R led_init_data --include='*.h'
>
> returns nothing..
>
> 27.08.19 23:56, Jacek Anaszewski пише:
>> Hi Oleh,
>>
>> On 8/27/19 10:43 PM, Oleh Kravchenko wrote:
>>> Hello Jacek,
>>>
>>> what status of linux-leds.git?
>>> git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
>>>
>>> Is it outdated? Because I have a errors:
>>> drivers/leds/leds-el15203000.c:234:9: error: variable ‘init_data’ has initializer but incomplete type
>>> struct led_init_data init_data = {};
>>
>> I've just compiled drivers/leds/leds-aat1290.c driver that contains the
>> same declaration and it went just fine.
>>
>> I know this is trivial, but did you "#include <linux/leds.h>" ?
>>
>

--
Best regards,
Jacek Anaszewski