Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board

Pavel Machek
2019-08-17T15:02:49Z

[-- Attachment #1: Type: text/plain, Size: 1902 bytes --]

Hi!

> >>>> All pattern is predefined, you can't change them at all.
> >>>> I just tried to describe real things what happened in LED board.
> >>>> It's ticks every 800 milliseconds for Pipe LEDs.
> >>>
> >>> It makes me wonder how you figured out the values? If you have
> >>> a documentation for this controller, could you share how the pattern
> >>> settings are documented?
> >>
> >> I saw the code of firmware.
> >> Not sure if I can find any documentation for it right now.
> >
> > Have you tried to alter the values? Or check what happens when
> > the duplication is removed?
>
> What do you mean alter? It doesn't make any sense.
> Board is accepts only brightness level from '0' to '5'.
> I'm really confused :-)

For the record, what you did seems ok to me.

> >> Ok, I will reduce it.
> >
> > Please hold on for a while. I will have some more remarks to the driver,
> > just collecting missing info for now to gain more complete view on this
> > device.
>
> Here is the full story:
>
> EL15203000 LEDs board (aka RED LEDs board, because it has only RED LEDs).
> It's provide access to 3 LEDs:
>
> - First LED (Screen) is a light tube around big 21" screen
> It's have 3 brightness levels:
> * OFF
> * ON
> * Breathing mode (8 seconds full cycle)
> - Second LED (Vending area) is highlight coffee cap
> * OFF
> * ON

Again, this is ok.

> - Third LED (Pipe) is actually virtual, because consists from 5 LEDs
> * OFF for all 5 LEDs
> * ON for all 5 LEDs
> * Cascade
> * Inverses cascade
> * Bounce
> * Inverses bounce

But having one virtual LED that is really five LEDs scares me a tiny
bit. But I guess its ok for your case...

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]