Re: [PATCH v4 2/2] leds: add LED driver for EL15203000 board

Oleh Kravchenko
2019-08-14T20:58:53Z

[-- Attachment #1.1: Type: text/plain, Size: 2422 bytes --]

By the way,

14.08.19 23:53, Jacek Anaszewski пише:
> On 8/14/19 10:16 PM, Oleh Kravchenko wrote:
>> Hello Jacek,
>>
>> 14.08.19 22:57, Jacek Anaszewski пише:
>>>>>>
>>>>>> All pattern is predefined, you can't change them at all.
>>>>>> I just tried to describe real things what happened in LED board.
>>>>>> It's ticks every 800 milliseconds for Pipe LEDs.
>>>>>
>>>>> It makes me wonder how you figured out the values? If you have
>>>>> a documentation for this controller, could you share how the pattern
>>>>> settings are documented?
>>>>
>>>> I saw the code of firmware.
>>>> Not sure if I can find any documentation for it right now.
>>>
>>> Have you tried to alter the values? Or check what happens when
>>> the duplication is removed?
>>
>> What do you mean alter? It doesn't make any sense.
>> Board is accepts only brightness level from '0' to '5'.
>> I'm really confused :-)
>
> OK, I didn't analyze the driver thoroughly enough.
> Now everything is clear to me. Patterns are triggered just
> by writing two-byte command.
>
>>>>>
>>>>> For the first two we could do without sequence duplication.
>>>>
>>>> Ok, I will reduce it.
>>>
>>> Please hold on for a while. I will have some more remarks to the driver,
>>> just collecting missing info for now to gain more complete view on this
>>> device.
>>
>> Here is the full story:
>>
>> EL15203000 LEDs board (aka RED LEDs board, because it has only RED LEDs).
>> It's provide access to 3 LEDs:
>>
>> - First LED (Screen) is a light tube around big 21" screen
>> It's have 3 brightness levels:
>> * OFF
>> * ON
>> * Breathing mode (8 seconds full cycle)
>
> OK, so this is LED string. We would need to bend rules to make it
> appearing as a single LED class device, but allowing non-synchronous
> blinking of LEDs in the string.
>
>> - Second LED (Vending area) is highlight coffee cap
>> * OFF
>> * ON
>> - Third LED (Pipe) is actually virtual, because consists from 5 LEDs
>> * OFF for all 5 LEDs
>> * ON for all 5 LEDs
>> * Cascade
>> * Inverses cascade
>> * Bounce
>> * Inverses bounce

Full cycle takes 8 seconds too.
So actually it's splitted into 10 stages, each takes 800ms.

> Similarly in case of this one. I will give you a feedback on how
> to define the patterns within few days.
>

Take you time.

--
Best regards,
Oleh Kravchenko

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]