[PATCH 1/6] leds: gpio: Include linux/of.h header

[PATCH 1/6] leds: gpio: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-gpio.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index e8b01e5..7ccafde 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -15,6 +15,7 @@
 #include <linux/platform_device.h>
 #include <linux/gpio.h>
 #include <linux/leds.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/of_gpio.h>
 #include <linux/slab.h>
-- 
1.7.9.5

[PATCH 2/6] leds: lp5523: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-lp5523.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index fe3bcbb..6b553d9 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -29,6 +29,7 @@
 #include <linux/leds.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/of.h>
 #include <linux/platform_data/leds-lp55xx.h>
 #include <linux/slab.h>
 
-- 
1.7.9.5

[PATCH 3/6] leds: lp5562: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-lp5562.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c
index 2585cfd..bf006f4 100644
--- a/drivers/leds/leds-lp5562.c
+++ b/drivers/leds/leds-lp5562.c
@@ -17,6 +17,7 @@
 #include <linux/leds.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/of.h>
 #include <linux/platform_data/leds-lp55xx.h>
 #include <linux/slab.h>
 
-- 
1.7.9.5

[PATCH 4/6] leds: lp8501: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-lp8501.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-lp8501.c b/drivers/leds/leds-lp8501.c
index 8d55a780..f1c704f 100644
--- a/drivers/leds/leds-lp8501.c
+++ b/drivers/leds/leds-lp8501.c
@@ -18,6 +18,7 @@
 #include <linux/leds.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/of.h>
 #include <linux/platform_data/leds-lp55xx.h>
 #include <linux/slab.h>
 
-- 
1.7.9.5

[PATCH 5/6] leds: ns2: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-ns2.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c
index 141f134..c7a4230 100644
--- a/drivers/leds/leds-ns2.c
+++ b/drivers/leds/leds-ns2.c
@@ -30,6 +30,7 @@
 #include <linux/leds.h>
 #include <linux/module.h>
 #include <linux/platform_data/leds-kirkwood-ns2.h>
+#include <linux/of.h>
 #include <linux/of_gpio.h>
 
 /*
-- 
1.7.9.5

[PATCH 6/6] leds: pwm: Include linux/of.h header

[Sachin Kamat]

'of_match_ptr' is defined in linux/of.h. Include it explicitly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/leds/leds-pwm.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index bb6f948..990f57e 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -24,6 +24,7 @@
 #include <linux/leds_pwm.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
+#include <linux/of.h>
 
 struct led_pwm_data {
 	struct led_classdev	cdev;
-- 
1.7.9.5

Re: [PATCH 1/6] leds: gpio: Include linux/of.h header

[Bryan Wu]

On Fri, Sep 27, 2013 at 4:36 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
>

Why we need this? I think it is include from of_gpio.h or
of_platform.h. And I tried to build these driver files you patched,
there is no error or warning for this.

Is there any error or warning you met?

Thanks,
-Bryan

> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/leds/leds-gpio.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index e8b01e5..7ccafde 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -15,6 +15,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/gpio.h>
>  #include <linux/leds.h>
> +#include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/of_gpio.h>
>  #include <linux/slab.h>
> --
> 1.7.9.5
>

Re: [PATCH 1/6] leds: gpio: Include linux/of.h header

[Sachin Kamat]

On 27 September 2013 22:23, Bryan Wu <cooloney@gmail.com> wrote:
> On Fri, Sep 27, 2013 at 4:36 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
>>
>
> Why we need this? I think it is include from of_gpio.h or
> of_platform.h. And I tried to build these driver files you patched,
> there is no error or warning for this.
>
> Is there any error or warning you met?

No, this is only a coding style best practice to include the header
files explicitly as is widely followed across the kernel. This will
avoid breakage in the future if the indirect inclusion is moved or
removed .

-- 
With warm regards,
Sachin

Re: [PATCH 1/6] leds: gpio: Include linux/of.h header

[Bryan Wu]

On Fri, Sep 27, 2013 at 10:02 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> On 27 September 2013 22:23, Bryan Wu <cooloney@gmail.com> wrote:
>> On Fri, Sep 27, 2013 at 4:36 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
>>>
>>
>> Why we need this? I think it is include from of_gpio.h or
>> of_platform.h. And I tried to build these driver files you patched,
>> there is no error or warning for this.
>>
>> Is there any error or warning you met?
>
> No, this is only a coding style best practice to include the header
> files explicitly as is widely followed across the kernel. This will
> avoid breakage in the future if the indirect inclusion is moved or
> removed .
>

OK, I assumed some building failures. Please help me to fold all you 6
patches together and we can apply them in one patch.

Thanks,
-Bryan

Re: [PATCH 1/6] leds: gpio: Include linux/of.h header

[Sachin Kamat]

On 27 September 2013 22:46, Bryan Wu <cooloney@gmail.com> wrote:
> On Fri, Sep 27, 2013 at 10:02 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>> On 27 September 2013 22:23, Bryan Wu <cooloney@gmail.com> wrote:
>>> On Fri, Sep 27, 2013 at 4:36 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
>>>> 'of_match_ptr' is defined in linux/of.h. Include it explicitly.
>>>>
>>>
>>> Why we need this? I think it is include from of_gpio.h or
>>> of_platform.h. And I tried to build these driver files you patched,
>>> there is no error or warning for this.
>>>
>>> Is there any error or warning you met?
>>
>> No, this is only a coding style best practice to include the header
>> files explicitly as is widely followed across the kernel. This will
>> avoid breakage in the future if the indirect inclusion is moved or
>> removed .
>>
>
> OK, I assumed some building failures. Please help me to fold all you 6
> patches together and we can apply them in one patch.

Ok. I will squash them together and send it to you in sometime.
Thanks.
-- 
With warm regards,
Sachin