From: Joe Perches <joe@perches.com>
To: NeilBrown <neilb@suse.de>
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Belisko Marek <marek.belisko@gmail.com>,
"Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: PATCH] LEDS: tca6507 - fix up some comments.
Date: Thu, 07 Nov 2013 19:24:36 -0800 [thread overview]
Message-ID: <1383881076.9263.64.camel@joe-AO722> (raw)
In-Reply-To: <20131108142004.10e31655@notabene.brown>
On Fri, 2013-11-08 at 14:20 +1100, NeilBrown wrote:
> In particular fix the capitalisation of GPIO and LED and
> correct TCA6507_MAKE_CPIO, but also rewrite the comment about
> platform-data to include reference to devicetree.
trivia:
> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
[]
> @@ -8,7 +8,7 @@
> * double-blink.
> *
> * This driver can configure each line either as a 'GPIO' which is out-only
> - * (no pull-up) or as an LED with variable brightness and hardware-assisted
> + * (pull-up resistor required) or as an LED with variable brightness and hardware-assisted
> * blinking.
Please rewrap the comment to 80 cols.
next prev parent reply other threads:[~2013-11-08 3:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 2:41 [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO configuration NeilBrown
2013-11-07 23:39 ` Bryan Wu
2013-11-07 23:46 ` NeilBrown
2013-11-07 23:46 ` Bryan Wu
2013-11-08 3:20 ` PATCH] LEDS: tca6507 - fix up some comments NeilBrown
2013-11-08 3:24 ` Joe Perches [this message]
2013-11-12 1:06 ` Bryan Wu
2013-11-13 5:52 ` [PATCH - v2] " NeilBrown
2013-11-18 11:55 ` [PATCH 2/2] LEDS: tca6502: add device-tree support for GPIO configuration Mark Rutland
2013-11-18 22:50 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383881076.9263.64.camel@joe-AO722 \
--to=joe@perches.com \
--cc=cooloney@gmail.com \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=neilb@suse.de \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).