* [PATCH] leds: s3c24xx: Fix build failure
@ 2013-12-30 9:09 Tushar Behera
2014-01-02 22:42 ` Bryan Wu
2014-01-03 5:25 ` [PATCH V2] " Tushar Behera
0 siblings, 2 replies; 7+ messages in thread
From: Tushar Behera @ 2013-12-30 9:09 UTC (permalink / raw)
To: linux-kernel, linux-leds; +Cc: rpurdie, cooloney
Fixes following build error.
drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
Tested at next-20131224.
drivers/leds/leds-s3c24xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 76483fb..87cf215 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -21,6 +21,7 @@
#include <mach/hardware.h>
#include <mach/regs-gpio.h>
+#include <plat/gpio-cfg.h>
#include <linux/platform_data/leds-s3c24xx.h>
/* our context */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] leds: s3c24xx: Fix build failure
2013-12-30 9:09 [PATCH] leds: s3c24xx: Fix build failure Tushar Behera
@ 2014-01-02 22:42 ` Bryan Wu
2014-01-03 5:05 ` Tushar Behera
2014-01-03 5:25 ` [PATCH V2] " Tushar Behera
1 sibling, 1 reply; 7+ messages in thread
From: Bryan Wu @ 2014-01-02 22:42 UTC (permalink / raw)
To: Tushar Behera; +Cc: lkml, Linux LED Subsystem, rpurdie@rpsys.net
On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <tushar.behera@linaro.org> wrote:
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>
I don't see any building error with s3c2410_defconfig. Actually this
<plat/gpio-cfg.h> is included in
arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
arch/arm/include/asm/gpio.h, then <linux/gpio.h>
Thanks,
-Bryan
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> Tested at next-20131224.
>
> drivers/leds/leds-s3c24xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index 76483fb..87cf215 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -21,6 +21,7 @@
>
> #include <mach/hardware.h>
> #include <mach/regs-gpio.h>
> +#include <plat/gpio-cfg.h>
> #include <linux/platform_data/leds-s3c24xx.h>
>
> /* our context */
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] leds: s3c24xx: Fix build failure
2014-01-02 22:42 ` Bryan Wu
@ 2014-01-03 5:05 ` Tushar Behera
0 siblings, 0 replies; 7+ messages in thread
From: Tushar Behera @ 2014-01-03 5:05 UTC (permalink / raw)
To: Bryan Wu; +Cc: lkml, Linux LED Subsystem, rpurdie@rpsys.net
On 3 January 2014 04:12, Bryan Wu <cooloney@gmail.com> wrote:
> On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <tushar.behera@linaro.org> wrote:
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>
>
> I don't see any building error with s3c2410_defconfig. Actually this
> <plat/gpio-cfg.h> is included in
> arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
> arch/arm/include/asm/gpio.h, then <linux/gpio.h>
>
This requires that CONFIG_NEED_MACH_GPIO_H is defined. Following
commit has removed this option for s3c24xx platform.
c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>").
--
Tushar Behera
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V2] leds: s3c24xx: Fix build failure
2013-12-30 9:09 [PATCH] leds: s3c24xx: Fix build failure Tushar Behera
2014-01-02 22:42 ` Bryan Wu
@ 2014-01-03 5:25 ` Tushar Behera
2014-01-03 6:19 ` Bryan Wu
1 sibling, 1 reply; 7+ messages in thread
From: Tushar Behera @ 2014-01-03 5:25 UTC (permalink / raw)
To: linux-kernel, linux-leds; +Cc: rpurdie, cooloney
Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
removed the usage of mach/gpio.h file, but we need to include
plat/gpio-cfg.h to avoid following build error.
Fixes following build error.
drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
Changes for V2:
* Updated commit message
Bryan,
I should have been more explicit regarding this patch. This patch fixes
build error on linux-next after the above patch was merged.
Tested at next-20131224.
drivers/leds/leds-s3c24xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 76483fb..87cf215 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -21,6 +21,7 @@
#include <mach/hardware.h>
#include <mach/regs-gpio.h>
+#include <plat/gpio-cfg.h>
#include <linux/platform_data/leds-s3c24xx.h>
/* our context */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH V2] leds: s3c24xx: Fix build failure
2014-01-03 5:25 ` [PATCH V2] " Tushar Behera
@ 2014-01-03 6:19 ` Bryan Wu
2014-01-07 17:41 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Bryan Wu @ 2014-01-03 6:19 UTC (permalink / raw)
To: Tushar Behera, Linus Walleij; +Cc: lkml, Linux LED Subsystem, rpurdie@rpsys.net
On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
> removed the usage of mach/gpio.h file, but we need to include
> plat/gpio-cfg.h to avoid following build error.
>
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>
I think this patch should go with Linus's patchset.
-Bryan
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
> Changes for V2:
> * Updated commit message
>
> Bryan,
>
> I should have been more explicit regarding this patch. This patch fixes
> build error on linux-next after the above patch was merged.
>
> Tested at next-20131224.
>
> drivers/leds/leds-s3c24xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index 76483fb..87cf215 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -21,6 +21,7 @@
>
> #include <mach/hardware.h>
> #include <mach/regs-gpio.h>
> +#include <plat/gpio-cfg.h>
> #include <linux/platform_data/leds-s3c24xx.h>
>
> /* our context */
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH V2] leds: s3c24xx: Fix build failure
2014-01-03 6:19 ` Bryan Wu
@ 2014-01-07 17:41 ` Linus Walleij
2014-01-07 17:43 ` Bryan Wu
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2014-01-07 17:41 UTC (permalink / raw)
To: Bryan Wu; +Cc: Tushar Behera, lkml, Linux LED Subsystem, rpurdie@rpsys.net
On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cooloney@gmail.com> wrote:
> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>> removed the usage of mach/gpio.h file, but we need to include
>> plat/gpio-cfg.h to avoid following build error.
>>
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>
>
> I think this patch should go with Linus's patchset.
Patch applied to the GPIO tree. I added your ACK Bryan since
that seems to be implied above ...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH V2] leds: s3c24xx: Fix build failure
2014-01-07 17:41 ` Linus Walleij
@ 2014-01-07 17:43 ` Bryan Wu
0 siblings, 0 replies; 7+ messages in thread
From: Bryan Wu @ 2014-01-07 17:43 UTC (permalink / raw)
To: Linus Walleij; +Cc: Tushar Behera, lkml, Linux LED Subsystem, rpurdie@rpsys.net
On Tue, Jan 7, 2014 at 9:41 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cooloney@gmail.com> wrote:
>> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar.behera@linaro.org> wrote:
>>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>>> removed the usage of mach/gpio.h file, but we need to include
>>> plat/gpio-cfg.h to avoid following build error.
>>>
>>> Fixes following build error.
>>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>>
>>
>> I think this patch should go with Linus's patchset.
>
> Patch applied to the GPIO tree. I added your ACK Bryan since
> that seems to be implied above ...
>
Sure, thanks.
-Bryan
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-07 17:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 9:09 [PATCH] leds: s3c24xx: Fix build failure Tushar Behera
2014-01-02 22:42 ` Bryan Wu
2014-01-03 5:05 ` Tushar Behera
2014-01-03 5:25 ` [PATCH V2] " Tushar Behera
2014-01-03 6:19 ` Bryan Wu
2014-01-07 17:41 ` Linus Walleij
2014-01-07 17:43 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).