linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Shiyan <shc_work@mail.ru>
To: linux-leds@vger.kernel.org
Cc: Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
	Alexander Shiyan <shc_work@mail.ru>
Subject: [PATCH v3 4/5] leds: leds-mc13783: Remove unnecessary cleaning of registers on exit
Date: Sat,  1 Feb 2014 10:36:31 +0400	[thread overview]
Message-ID: <1391236591-16540-4-git-send-email-shc_work@mail.ru> (raw)
In-Reply-To: <1391236591-16540-1-git-send-email-shc_work@mail.ru>

LED core switches each LED to OFF-state on exit, so there is no need
for resetting registers.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/leds/leds-mc13783.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
index 2360eca..4cfcfde 100644
--- a/drivers/leds/leds-mc13783.c
+++ b/drivers/leds/leds-mc13783.c
@@ -209,7 +209,6 @@ static int __init mc13xxx_led_probe(struct platform_device *pdev)
 static int mc13xxx_led_remove(struct platform_device *pdev)
 {
 	struct mc13xxx_leds *leds = platform_get_drvdata(pdev);
-	struct mc13xxx *mcdev = leds->master;
 	int i;
 
 	for (i = 0; i < leds->num_leds; i++) {
@@ -217,9 +216,6 @@ static int mc13xxx_led_remove(struct platform_device *pdev)
 		cancel_work_sync(&leds->led[i].work);
 	}
 
-	for (i = 0; i < leds->devtype->num_regs; i++)
-		mc13xxx_reg_write(mcdev, leds->devtype->ledctrl_base + i, 0);
-
 	return 0;
 }
 
-- 
1.8.3.2

      parent reply	other threads:[~2014-02-01  6:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-01  6:36 [PATCH v3 1/5] leds: leds-mc13783: Add MC34708 LED support Alexander Shiyan
2014-02-01  6:36 ` [PATCH v3 2/5] leds: leds-mc13783: Use LED core PM functions Alexander Shiyan
2014-02-01  6:36 ` [PATCH v3 3/5] leds: leds-mc13783: Use proper "max_brightness" value fo LEDs Alexander Shiyan
2014-02-01  6:36 ` Alexander Shiyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391236591-16540-4-git-send-email-shc_work@mail.ru \
    --to=shc_work@mail.ru \
    --cc=cooloney@gmail.com \
    --cc=linux-leds@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).