* [PATCH 1/6] leds: bd2802: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-04-30 8:07 ` [PATCH 2/6] leds: da903x: " Xiubo Li
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-bd2802.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c
index fb5a347..6078c15 100644
--- a/drivers/leds/leds-bd2802.c
+++ b/drivers/leds/leds-bd2802.c
@@ -678,10 +678,8 @@ static int bd2802_probe(struct i2c_client *client,
int ret, i;
led = devm_kzalloc(&client->dev, sizeof(struct bd2802_led), GFP_KERNEL);
- if (!led) {
- dev_err(&client->dev, "failed to allocate driver data\n");
+ if (!led)
return -ENOMEM;
- }
led->client = client;
pdata = led->pdata = dev_get_platdata(&client->dev);
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/6] leds: da903x: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
2014-04-30 8:07 ` [PATCH 1/6] leds: bd2802: " Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-04-30 8:07 ` [PATCH 3/6] leds: da9052: " Xiubo Li
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-da903x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-da903x.c b/drivers/leds/leds-da903x.c
index 2a4b87f..180bbd8 100644
--- a/drivers/leds/leds-da903x.c
+++ b/drivers/leds/leds-da903x.c
@@ -109,10 +109,8 @@ static int da903x_led_probe(struct platform_device *pdev)
}
led = devm_kzalloc(&pdev->dev, sizeof(struct da903x_led), GFP_KERNEL);
- if (led == NULL) {
- dev_err(&pdev->dev, "failed to alloc memory for LED%d\n", id);
+ if (!led)
return -ENOMEM;
- }
led->cdev.name = pdata->name;
led->cdev.default_trigger = pdata->default_trigger;
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/6] leds: da9052: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
2014-04-30 8:07 ` [PATCH 1/6] leds: bd2802: " Xiubo Li
2014-04-30 8:07 ` [PATCH 2/6] leds: da903x: " Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-04-30 8:07 ` [PATCH 4/6] leds: s3c24xx: " Xiubo Li
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-da9052.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/leds/leds-da9052.c b/drivers/leds/leds-da9052.c
index 865d4fa..5aa7e31 100644
--- a/drivers/leds/leds-da9052.c
+++ b/drivers/leds/leds-da9052.c
@@ -127,8 +127,7 @@ static int da9052_led_probe(struct platform_device *pdev)
led = devm_kzalloc(&pdev->dev,
sizeof(struct da9052_led) * pled->num_leds,
GFP_KERNEL);
- if (led == NULL) {
- dev_err(&pdev->dev, "Failed to alloc memory\n");
+ if (!led) {
error = -ENOMEM;
goto err;
}
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 4/6] leds: s3c24xx: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
` (2 preceding siblings ...)
2014-04-30 8:07 ` [PATCH 3/6] leds: da9052: " Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-04-30 8:07 ` [PATCH 5/6] leds: sunfire: " Xiubo Li
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-s3c24xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
index 98174e7..37a6a92 100644
--- a/drivers/leds/leds-s3c24xx.c
+++ b/drivers/leds/leds-s3c24xx.c
@@ -77,10 +77,8 @@ static int s3c24xx_led_probe(struct platform_device *dev)
led = devm_kzalloc(&dev->dev, sizeof(struct s3c24xx_gpio_led),
GFP_KERNEL);
- if (led == NULL) {
- dev_err(&dev->dev, "No memory for device\n");
+ if (!led)
return -ENOMEM;
- }
platform_set_drvdata(dev, led);
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/6] leds: sunfire: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
` (3 preceding siblings ...)
2014-04-30 8:07 ` [PATCH 4/6] leds: s3c24xx: " Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-04-30 8:07 ` [PATCH 6/6] leds: adp5520: " Xiubo Li
2014-05-08 1:58 ` [PATCH 0/6] leds: " Bryan Wu
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-sunfire.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-sunfire.c b/drivers/leds/leds-sunfire.c
index 388632d..0b8cc4a 100644
--- a/drivers/leds/leds-sunfire.c
+++ b/drivers/leds/leds-sunfire.c
@@ -135,10 +135,8 @@ static int sunfire_led_generic_probe(struct platform_device *pdev,
}
p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
- if (!p) {
- dev_err(&pdev->dev, "Could not allocate struct sunfire_drvdata\n");
+ if (!p)
return -ENOMEM;
- }
for (i = 0; i < NUM_LEDS_PER_BOARD; i++) {
struct led_classdev *lp = &p->leds[i].led_cdev;
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 6/6] leds: adp5520: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
` (4 preceding siblings ...)
2014-04-30 8:07 ` [PATCH 5/6] leds: sunfire: " Xiubo Li
@ 2014-04-30 8:07 ` Xiubo Li
2014-05-08 1:58 ` [PATCH 0/6] leds: " Bryan Wu
6 siblings, 0 replies; 9+ messages in thread
From: Xiubo Li @ 2014-04-30 8:07 UTC (permalink / raw)
To: cooloney, rpurdie, linux-leds, michael.hennerich; +Cc: Xiubo Li
The OOM message of individual driver is unnecessary, and this is
duplicate the memory subsystem generic OOM message.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
drivers/leds/leds-adp5520.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/leds/leds-adp5520.c b/drivers/leds/leds-adp5520.c
index 7e311a1..9982691 100644
--- a/drivers/leds/leds-adp5520.c
+++ b/drivers/leds/leds-adp5520.c
@@ -121,13 +121,10 @@ static int adp5520_led_probe(struct platform_device *pdev)
led = devm_kzalloc(&pdev->dev, sizeof(*led) * pdata->num_leds,
GFP_KERNEL);
- if (led == NULL) {
- dev_err(&pdev->dev, "failed to alloc memory\n");
+ if (!led)
return -ENOMEM;
- }
ret = adp5520_led_prepare(pdev);
-
if (ret) {
dev_err(&pdev->dev, "failed to write\n");
return ret;
--
1.8.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/6] leds: Remove duplicated OOM message for individual driver
2014-04-30 8:07 [PATCH 0/6] leds: Remove duplicated OOM message for individual driver Xiubo Li
` (5 preceding siblings ...)
2014-04-30 8:07 ` [PATCH 6/6] leds: adp5520: " Xiubo Li
@ 2014-05-08 1:58 ` Bryan Wu
2014-05-08 3:36 ` Li.Xiubo
6 siblings, 1 reply; 9+ messages in thread
From: Bryan Wu @ 2014-05-08 1:58 UTC (permalink / raw)
To: Xiubo Li; +Cc: rpurdie@rpsys.net, Linux LED Subsystem, Hennerich, Michael
On Wed, Apr 30, 2014 at 1:07 AM, Xiubo Li <Li.Xiubo@freescale.com> wrote:
>
> Xiubo Li (6):
> leds: bd2802: Remove duplicated OOM message for individual driver
> leds: da903x: Remove duplicated OOM message for individual driver
> leds: da9052: Remove duplicated OOM message for individual driver
> leds: s3c24xx: Remove duplicated OOM message for individual driver
> leds: sunfire: Remove duplicated OOM message for individual driver
> leds: adp5520: Remove duplicated OOM message for individual driver
>
This patchset looks good to me, could you please fold them together? I
can apply it in one shot?
Thanks,
-Bryan
> drivers/leds/leds-adp5520.c | 5 +----
> drivers/leds/leds-bd2802.c | 4 +---
> drivers/leds/leds-da903x.c | 4 +---
> drivers/leds/leds-da9052.c | 3 +--
> drivers/leds/leds-s3c24xx.c | 4 +---
> drivers/leds/leds-sunfire.c | 4 +---
> 6 files changed, 6 insertions(+), 18 deletions(-)
>
> --
> 1.8.4
>
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH 0/6] leds: Remove duplicated OOM message for individual driver
2014-05-08 1:58 ` [PATCH 0/6] leds: " Bryan Wu
@ 2014-05-08 3:36 ` Li.Xiubo
0 siblings, 0 replies; 9+ messages in thread
From: Li.Xiubo @ 2014-05-08 3:36 UTC (permalink / raw)
To: Bryan Wu; +Cc: rpurdie@rpsys.net, Linux LED Subsystem, Hennerich, Michael
> On Wed, Apr 30, 2014 at 1:07 AM, Xiubo Li <Li.Xiubo@freescale.com> wrote:
> >
> > Xiubo Li (6):
> > leds: bd2802: Remove duplicated OOM message for individual driver
> > leds: da903x: Remove duplicated OOM message for individual driver
> > leds: da9052: Remove duplicated OOM message for individual driver
> > leds: s3c24xx: Remove duplicated OOM message for individual driver
> > leds: sunfire: Remove duplicated OOM message for individual driver
> > leds: adp5520: Remove duplicated OOM message for individual driver
> >
>
> This patchset looks good to me, could you please fold them together? I
> can apply it in one shot?
>
Sure, I just thought they maybe acked or reviewed by different owners.
Since you have agreed of these changing, I will fold them together and
Resent it.
Thanks,
BRs
Xiubo
> Thanks,
> -Bryan
>
> > drivers/leds/leds-adp5520.c | 5 +----
> > drivers/leds/leds-bd2802.c | 4 +---
> > drivers/leds/leds-da903x.c | 4 +---
> > drivers/leds/leds-da9052.c | 3 +--
> > drivers/leds/leds-s3c24xx.c | 4 +---
> > drivers/leds/leds-sunfire.c | 4 +---
> > 6 files changed, 6 insertions(+), 18 deletions(-)
> >
> > --
> > 1.8.4
> >
^ permalink raw reply [flat|nested] 9+ messages in thread