* [PATCH] leds: leds-pwm: drop one pwm_get_period() call
@ 2015-02-06 16:04 Sebastian Andrzej Siewior
2015-02-12 19:22 ` Bryan Wu
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2015-02-06 16:04 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie; +Cc: linux-leds, Sebastian Andrzej Siewior
pwm_get_period() is called twice in case the child parameter is set. I
assume retrieving this parameter once is enough therefore this patch
removes the conditial invocation of pwm_get_period().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/leds/leds-pwm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index f668500a2157..1d07e3e83d29 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -119,13 +119,10 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
dev_err(dev, "unable to request PWM for %s: %d\n",
led->name, ret);
return ret;
}
- if (child)
- led_data->period = pwm_get_period(led_data->pwm);
-
led_data->can_sleep = pwm_can_sleep(led_data->pwm);
if (led_data->can_sleep)
INIT_WORK(&led_data->work, led_pwm_work);
led_data->period = pwm_get_period(led_data->pwm);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] leds: leds-pwm: drop one pwm_get_period() call
2015-02-06 16:04 [PATCH] leds: leds-pwm: drop one pwm_get_period() call Sebastian Andrzej Siewior
@ 2015-02-12 19:22 ` Bryan Wu
0 siblings, 0 replies; 2+ messages in thread
From: Bryan Wu @ 2015-02-12 19:22 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Richard Purdie, Linux LED Subsystem
On Fri, Feb 6, 2015 at 8:04 AM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> pwm_get_period() is called twice in case the child parameter is set. I
> assume retrieving this parameter once is enough therefore this patch
> removes the conditial invocation of pwm_get_period().
>
Good catch, I will merge this patch
-Bryan
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/leds/leds-pwm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index f668500a2157..1d07e3e83d29 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -119,13 +119,10 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
> dev_err(dev, "unable to request PWM for %s: %d\n",
> led->name, ret);
> return ret;
> }
>
> - if (child)
> - led_data->period = pwm_get_period(led_data->pwm);
> -
> led_data->can_sleep = pwm_can_sleep(led_data->pwm);
> if (led_data->can_sleep)
> INIT_WORK(&led_data->work, led_pwm_work);
>
> led_data->period = pwm_get_period(led_data->pwm);
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-12 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-06 16:04 [PATCH] leds: leds-pwm: drop one pwm_get_period() call Sebastian Andrzej Siewior
2015-02-12 19:22 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).