* [PATCH 3/3] leds/class: Set naming index as unsigned
2015-03-30 8:55 [PATCH 0/3] leds/class: Fix string handling Ricardo Ribalda Delgado
@ 2015-03-30 8:55 ` Ricardo Ribalda Delgado
2015-03-30 8:59 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-03-30 8:55 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, linux-leds, linux-kernel,
Geert Uytterhoeven
Cc: Ricardo Ribalda Delgado
Avoid weird names (led_-65537) on overflows.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 2ffe8b1..2be1ba3 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -222,7 +222,7 @@ static int match_name(struct device *dev, const void *data)
static int led_classdev_next_name(const char *init_name, char *name,
size_t len)
{
- int i = 0;
+ unsigned int i = 0;
int ret = 0;
strlcpy(name, init_name, len);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] leds/class: Set naming index as unsigned
2015-03-30 8:55 ` [PATCH 3/3] leds/class: Set naming index as unsigned Ricardo Ribalda Delgado
@ 2015-03-30 8:59 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-03-30 8:59 UTC (permalink / raw)
To: Ricardo Ribalda Delgado
Cc: Bryan Wu, Richard Purdie, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
On Mon, Mar 30, 2015 at 10:55 AM, Ricardo Ribalda Delgado
<ricardo.ribalda@gmail.com> wrote:
> - int i = 0;
> + unsigned int i = 0;
That won't help, as you forgot to replace "%d" by "%u" in the snprintf()
call.
> int ret = 0;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 3/3] leds/class: Set naming index as unsigned
@ 2015-03-30 9:09 Ricardo Ribalda Delgado
0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2015-03-30 9:09 UTC (permalink / raw)
To: Bryan Wu, Richard Purdie, linux-leds, linux-kernel,
Geert Uytterhoeven
Cc: Ricardo Ribalda Delgado
Avoid weird names (led_-65537) on overflows.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/leds/led-class.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 2ffe8b1..2be1ba3 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -222,7 +222,7 @@ static int match_name(struct device *dev, const void *data)
static int led_classdev_next_name(const char *init_name, char *name,
size_t len)
{
- int i = 0;
+ unsigned int i = 0;
int ret = 0;
strlcpy(name, init_name, len);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-30 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 9:09 [PATCH 3/3] leds/class: Set naming index as unsigned Ricardo Ribalda Delgado
-- strict thread matches above, loose matches on Subject: below --
2015-03-30 8:55 [PATCH 0/3] leds/class: Fix string handling Ricardo Ribalda Delgado
2015-03-30 8:55 ` [PATCH 3/3] leds/class: Set naming index as unsigned Ricardo Ribalda Delgado
2015-03-30 8:59 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).