* [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
@ 2015-07-26 4:05 Axel Lin
2015-07-26 17:31 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2015-07-26 4:05 UTC (permalink / raw)
To: Bryan Wu; +Cc: Andrew Lunn, Jacek Anaszewski, linux-leds
This checking is done by regmap_get_i2c_bus() which is called in
devm_regmap_init_i2c().
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/leds/leds-tlc591xx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
index de16c29..b806eca 100644
--- a/drivers/leds/leds-tlc591xx.c
+++ b/drivers/leds/leds-tlc591xx.c
@@ -231,10 +231,6 @@ tlc591xx_probe(struct i2c_client *client,
if (!count || count > tlc591xx->max_leds)
return -EINVAL;
- if (!i2c_check_functionality(client->adapter,
- I2C_FUNC_SMBUS_BYTE_DATA))
- return -EIO;
-
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
2015-07-26 4:05 [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check Axel Lin
@ 2015-07-26 17:31 ` Andrew Lunn
2015-07-30 21:00 ` Jacek Anaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2015-07-26 17:31 UTC (permalink / raw)
To: Axel Lin; +Cc: Bryan Wu, Jacek Anaszewski, linux-leds
On Sun, Jul 26, 2015 at 12:05:16PM +0800, Axel Lin wrote:
> This checking is done by regmap_get_i2c_bus() which is called in
> devm_regmap_init_i2c().
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
Andrew
> ---
> drivers/leds/leds-tlc591xx.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/leds/leds-tlc591xx.c b/drivers/leds/leds-tlc591xx.c
> index de16c29..b806eca 100644
> --- a/drivers/leds/leds-tlc591xx.c
> +++ b/drivers/leds/leds-tlc591xx.c
> @@ -231,10 +231,6 @@ tlc591xx_probe(struct i2c_client *client,
> if (!count || count > tlc591xx->max_leds)
> return -EINVAL;
>
> - if (!i2c_check_functionality(client->adapter,
> - I2C_FUNC_SMBUS_BYTE_DATA))
> - return -EIO;
> -
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
> --
> 2.1.0
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check
2015-07-26 17:31 ` Andrew Lunn
@ 2015-07-30 21:00 ` Jacek Anaszewski
0 siblings, 0 replies; 3+ messages in thread
From: Jacek Anaszewski @ 2015-07-30 21:00 UTC (permalink / raw)
To: Andrew Lunn, Axel Lin; +Cc: Bryan Wu, Jacek Anaszewski, linux-leds
On 26.07.2015 19:31, Andrew Lunn wrote:
> On Sun, Jul 26, 2015 at 12:05:16PM +0800, Axel Lin wrote:
>> This checking is done by regmap_get_i2c_bus() which is called in
>> devm_regmap_init_i2c().
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-30 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-26 4:05 [PATCH] leds: tlc591xx: Remove redundant I2C_FUNC_SMBUS_BYTE_DATA functionality check Axel Lin
2015-07-26 17:31 ` Andrew Lunn
2015-07-30 21:00 ` Jacek Anaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).